All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net, donald.hunter@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 11/12] netlink: specs: rtnetlink: correct notify properties
Date: Thu, 17 Apr 2025 19:17:05 -0700	[thread overview]
Message-ID: <20250418021706.1967583-12-kuba@kernel.org> (raw)
In-Reply-To: <20250418021706.1967583-1-kuba@kernel.org>

The notify property should point at the object the notifications
carry, usually the get object, not the cmd which triggers
the notification:

  notify:
    description: Name of the command sharing the reply type with
                 this notification.

Not treating this as a fix, I think that only C codegen cares.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 Documentation/netlink/specs/rt-neigh.yaml | 2 +-
 Documentation/netlink/specs/rt-rule.yaml  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/netlink/specs/rt-neigh.yaml b/Documentation/netlink/specs/rt-neigh.yaml
index fe34ade6b300..e9cba164e3d1 100644
--- a/Documentation/netlink/specs/rt-neigh.yaml
+++ b/Documentation/netlink/specs/rt-neigh.yaml
@@ -381,7 +381,7 @@ protonum: 0
       name: delneigh-ntf
       doc: Notify a neighbour deletion
       value: 29
-      notify: delneigh
+      notify: getneigh
       fixed-header: ndmsg
     -
       name: getneigh
diff --git a/Documentation/netlink/specs/rt-rule.yaml b/Documentation/netlink/specs/rt-rule.yaml
index de0938d36541..f585654a4d41 100644
--- a/Documentation/netlink/specs/rt-rule.yaml
+++ b/Documentation/netlink/specs/rt-rule.yaml
@@ -234,7 +234,7 @@ protonum: 0
       name: newrule-ntf
       doc: Notify a rule creation
       value: 32
-      notify: newrule
+      notify: getrule
     -
       name: delrule
       doc: Remove an existing FIB rule
@@ -247,7 +247,7 @@ protonum: 0
       name: delrule-ntf
       doc: Notify a rule deletion
       value: 33
-      notify: delrule
+      notify: getrule
     -
       name: getrule
       doc: Dump all FIB rules
-- 
2.49.0


  parent reply	other threads:[~2025-04-18  2:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  2:16 [PATCH net-next 00/12] netlink: specs: rtnetlink: adjust specs for C codegen Jakub Kicinski
2025-04-18  2:16 ` [PATCH net-next 01/12] netlink: specs: allow header properties for attribute sets Jakub Kicinski
2025-04-18 10:20   ` Donald Hunter
2025-04-18  2:16 ` [PATCH net-next 02/12] netlink: specs: rt-link: remove the fixed members from attrs Jakub Kicinski
2025-04-18 10:27   ` Donald Hunter
2025-04-18  2:16 ` [PATCH net-next 03/12] netlink: specs: rt-link: remove if-netnsid from attr list Jakub Kicinski
2025-04-18 10:31   ` Donald Hunter
2025-04-18  2:16 ` [PATCH net-next 04/12] netlink: specs: rt-link: remove duplicated group in " Jakub Kicinski
2025-04-18 10:32   ` Donald Hunter
2025-04-18  2:16 ` [PATCH net-next 05/12] netlink: specs: rt-link: add C naming info Jakub Kicinski
2025-04-18 10:36   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 06/12] netlink: specs: rt-link: adjust AF_ nest for C codegen Jakub Kicinski
2025-04-18 10:39   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 07/12] netlink: specs: rt-link: make bond's ipv6 address attribute fixed size Jakub Kicinski
2025-04-18 10:39   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 08/12] netlink: specs: rt-link: add notification for newlink Jakub Kicinski
2025-04-18 10:41   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 09/12] netlink: specs: rt-neigh: add C naming info Jakub Kicinski
2025-04-18 10:42   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 10/12] netlink: specs: rt-neigh: make sure getneigh is consistent Jakub Kicinski
2025-04-18 10:45   ` Donald Hunter
2025-04-18  2:17 ` Jakub Kicinski [this message]
2025-04-18 10:46   ` [PATCH net-next 11/12] netlink: specs: rtnetlink: correct notify properties Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 12/12] netlink: specs: rt-rule: add C naming info Jakub Kicinski
2025-04-18 10:46   ` Donald Hunter
2025-04-23 23:20 ` [PATCH net-next 00/12] netlink: specs: rtnetlink: adjust specs for C codegen patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250418021706.1967583-12-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.