From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] crypto: lib/poly1305 - restore ability to remove modules
Date: Thu, 17 Apr 2025 21:00:17 -0700 [thread overview]
Message-ID: <20250418040017.65086-1-ebiggers@kernel.org> (raw)
From: Eric Biggers <ebiggers@google.com>
Though the module_exit functions are now no-ops, they should still be
defined, since otherwise the modules become unremovable.
Fixes: 1f81c58279c7 ("crypto: arm/poly1305 - remove redundant shash algorithm")
Fixes: f4b1a73aec5c ("crypto: arm64/poly1305 - remove redundant shash algorithm")
Fixes: 378a337ab40f ("crypto: powerpc/poly1305 - implement library instead of shash")
Fixes: 21969da642a2 ("crypto: x86/poly1305 - remove redundant shash algorithm")
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
arch/arm/crypto/poly1305-glue.c | 5 +++++
arch/arm64/crypto/poly1305-glue.c | 5 +++++
arch/powerpc/crypto/poly1305-p10-glue.c | 5 +++++
arch/x86/crypto/poly1305_glue.c | 5 +++++
4 files changed, 20 insertions(+)
diff --git a/arch/arm/crypto/poly1305-glue.c b/arch/arm/crypto/poly1305-glue.c
index 6d6998b3ec7e3..42d0ebde1ae15 100644
--- a/arch/arm/crypto/poly1305-glue.c
+++ b/arch/arm/crypto/poly1305-glue.c
@@ -114,7 +114,12 @@ static int __init arm_poly1305_mod_init(void)
static_branch_enable(&have_neon);
return 0;
}
arch_initcall(arm_poly1305_mod_init);
+static void __exit arm_poly1305_mod_exit(void)
+{
+}
+module_exit(arm_poly1305_mod_exit);
+
MODULE_DESCRIPTION("Accelerated Poly1305 transform for ARM");
MODULE_LICENSE("GPL v2");
diff --git a/arch/arm64/crypto/poly1305-glue.c b/arch/arm64/crypto/poly1305-glue.c
index cb152ceac14a1..906970dd53732 100644
--- a/arch/arm64/crypto/poly1305-glue.c
+++ b/arch/arm64/crypto/poly1305-glue.c
@@ -105,7 +105,12 @@ static int __init neon_poly1305_mod_init(void)
static_branch_enable(&have_neon);
return 0;
}
arch_initcall(neon_poly1305_mod_init);
+static void __exit neon_poly1305_mod_exit(void)
+{
+}
+module_exit(neon_poly1305_mod_exit);
+
MODULE_DESCRIPTION("Poly1305 authenticator (ARM64 optimized)");
MODULE_LICENSE("GPL v2");
diff --git a/arch/powerpc/crypto/poly1305-p10-glue.c b/arch/powerpc/crypto/poly1305-p10-glue.c
index 40d296d52c23e..00617f4c58e69 100644
--- a/arch/powerpc/crypto/poly1305-p10-glue.c
+++ b/arch/powerpc/crypto/poly1305-p10-glue.c
@@ -125,8 +125,13 @@ static int __init poly1305_p10_init(void)
static_branch_enable(&have_p10);
return 0;
}
arch_initcall(poly1305_p10_init);
+static void __exit poly1305_p10_exit(void)
+{
+}
+module_exit(poly1305_p10_exit);
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Danny Tsen <dtsen@linux.ibm.com>");
MODULE_DESCRIPTION("Optimized Poly1305 for P10");
diff --git a/arch/x86/crypto/poly1305_glue.c b/arch/x86/crypto/poly1305_glue.c
index a0fc543a0d688..cff35ca5822a8 100644
--- a/arch/x86/crypto/poly1305_glue.c
+++ b/arch/x86/crypto/poly1305_glue.c
@@ -206,8 +206,13 @@ static int __init poly1305_simd_mod_init(void)
static_branch_enable(&poly1305_use_avx512);
return 0;
}
arch_initcall(poly1305_simd_mod_init);
+static void __exit poly1305_simd_mod_exit(void)
+{
+}
+module_exit(poly1305_simd_mod_exit);
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
MODULE_DESCRIPTION("Poly1305 authenticator");
base-commit: da4cb617bc7d827946cbb368034940b379a1de90
--
2.49.0
next reply other threads:[~2025-04-18 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 4:00 Eric Biggers [this message]
2025-04-19 3:21 ` [PATCH] crypto: lib/poly1305 - restore ability to remove modules Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418040017.65086-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.