Re: [PATCH 0/3] booti: Remove the SYS_BOOTM_LEN limit for booti

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]

On Fri, Apr 18, 2025 at 06:50:59AM -0600, Simon Glass wrote:

> This series restores the original behaviour of extlinux booting linux
> 'Image' files, which is to ignore CONFIG_SYS_BOOTM_LEN and instead uses
> a limit of 10x the compressed size.
> 
> It also adds RISC-V support, since it uses a similar format to ARM64.
> 
> Future work should integrate the code in 'booti' into main 'bootm'
> logic.
> 
> 
> Simon Glass (3):
>   boot: Add a function to check if a linux Image is supported
>   bootm: Add RISC-V support in booti_is_supported()
>   booti: Allow ignoring SYS_BOOTM_LEN with the booti command
> 
>  boot/bootm.c    | 31 +++++++++++++++++++++++++------
>  cmd/booti.c     |  1 +
>  include/bootm.h |  3 +++
>  3 files changed, 29 insertions(+), 6 deletions(-)

This is like pulling teeth. We aren't ignoring SYS_BOOTM_LEN so much as
it was never relevant here to start with. The documentation
(doc/usage/cmd/booti.rst) has explained that we use 10 x
kernel_comp_size for the limit. The "bootm" namespace has largely been
about uImage (and then FIT images when not using it's own namespace)
images and not applied elsewhere, which is why bootz/booti handled
things outside that namespace. And then, still, this series doesn't
unify cmd/booti.c with your changes, it just introduces duplicated
functionality, which is generally understood to be a bad thing.

So again, please do similar to what you did for cmd/bootz.c and that
report and move the existing functionality over. We can then look at
cleaning it up (which should look like / abstract what we do for
compressed FIT images) as a follow up, in order to make bisecting any
regressions here easier down the line. Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]