Re: [PATCH ath-next v5 2/6] wifi: ath12k: correctly fetch arsta for MLO

[kernel test robot <lkp@intel.com>]

Hi Sarika,

kernel test robot noticed the following build errors:

[auto build test ERROR on b80c52642c1159c2596776b39b06eb1c2e36baff]

url:    https://github.com/intel-lab-lkp/linux/commits/Sarika-Sharma/wifi-ath12k-enable-wiphy-flag-for-MLO-station-statistics-support/20250417-130053
base:   b80c52642c1159c2596776b39b06eb1c2e36baff
patch link:    https://lore.kernel.org/r/20250417045709.770219-3-quic_sarishar%40quicinc.com
patch subject: [PATCH ath-next v5 2/6] wifi: ath12k: correctly fetch arsta for MLO
config: arm-randconfig-001-20250418 (https://download.01.org/0day-ci/archive/20250418/202504181412.uGSvIIlb-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250418/202504181412.uGSvIIlb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504181412.uGSvIIlb-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/wireless/ath/ath12k/mac.c: In function 'ath12k_mac_op_sta_statistics':
>> drivers/net/wireless/ath/ath12k/mac.c:10506:21: error: 'struct station_info' has no member named 'link_id'
     int link_id = sinfo->link_id;
                        ^~
   drivers/net/wireless/ath/ath12k/mac.c: In function 'ath12k_mac_hw_register':
   drivers/net/wireless/ath/ath12k/mac.c:11472:18: error: 'WIPHY_FLAG_SUPPORTS_MLO_STA_PER_LINK_STATS' undeclared (first use in this function); did you mean 'WIPHY_FLAG_SUPPORTS_NSTR_NONPRIMARY'?
     wiphy->flags |= WIPHY_FLAG_SUPPORTS_MLO_STA_PER_LINK_STATS;
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                     WIPHY_FLAG_SUPPORTS_NSTR_NONPRIMARY
   drivers/net/wireless/ath/ath12k/mac.c:11472:18: note: each undeclared identifier is reported only once for each function it appears in


vim +10506 drivers/net/wireless/ath/ath12k/mac.c

 10497	
 10498	static void ath12k_mac_op_sta_statistics(struct ieee80211_hw *hw,
 10499						 struct ieee80211_vif *vif,
 10500						 struct ieee80211_sta *sta,
 10501						 struct station_info *sinfo)
 10502	{
 10503		struct ath12k_sta *ahsta = ath12k_sta_to_ahsta(sta);
 10504		struct ath12k_fw_stats_req_params params = {};
 10505		struct ath12k_link_sta *arsta;
 10506		int link_id = sinfo->link_id;
 10507		struct ath12k *ar;
 10508		s8 signal;
 10509		bool db2dbm;
 10510	
 10511		lockdep_assert_wiphy(hw->wiphy);
 10512	
 10513		if (link_id < 0)
 10514			arsta = &ahsta->deflink;
 10515		else
 10516			arsta = wiphy_dereference(hw->wiphy, ahsta->link[link_id]);
 10517	
 10518		if (!arsta)
 10519			return;
 10520	
 10521		ar = ath12k_get_ar_by_vif(hw, vif, arsta->link_id);
 10522		if (!ar)
 10523			return;
 10524	
 10525		db2dbm = test_bit(WMI_TLV_SERVICE_HW_DB2DBM_CONVERSION_SUPPORT,
 10526				  ar->ab->wmi_ab.svc_map);
 10527	
 10528		sinfo->rx_duration = arsta->rx_duration;
 10529		sinfo->filled |= BIT_ULL(NL80211_STA_INFO_RX_DURATION);
 10530	
 10531		sinfo->tx_duration = arsta->tx_duration;
 10532		sinfo->filled |= BIT_ULL(NL80211_STA_INFO_TX_DURATION);
 10533	
 10534		if (arsta->txrate.legacy || arsta->txrate.nss) {
 10535			if (arsta->txrate.legacy) {
 10536				sinfo->txrate.legacy = arsta->txrate.legacy;
 10537			} else {
 10538				sinfo->txrate.mcs = arsta->txrate.mcs;
 10539				sinfo->txrate.nss = arsta->txrate.nss;
 10540				sinfo->txrate.bw = arsta->txrate.bw;
 10541				sinfo->txrate.he_gi = arsta->txrate.he_gi;
 10542				sinfo->txrate.he_dcm = arsta->txrate.he_dcm;
 10543				sinfo->txrate.he_ru_alloc = arsta->txrate.he_ru_alloc;
 10544				sinfo->txrate.eht_gi = arsta->txrate.eht_gi;
 10545				sinfo->txrate.eht_ru_alloc = arsta->txrate.eht_ru_alloc;
 10546			}
 10547			sinfo->txrate.flags = arsta->txrate.flags;
 10548			sinfo->filled |= BIT_ULL(NL80211_STA_INFO_TX_BITRATE);
 10549		}
 10550	
 10551		/* TODO: Use real NF instead of default one. */
 10552		signal = arsta->rssi_comb;
 10553	
 10554		params.pdev_id = ar->pdev->pdev_id;
 10555		params.vdev_id = 0;
 10556		params.stats_id = WMI_REQUEST_VDEV_STAT;
 10557	
 10558		if (!signal &&
 10559		    ahsta->ahvif->vdev_type == WMI_VDEV_TYPE_STA &&
 10560		    !(ath12k_mac_get_fw_stats(ar, &params)))
 10561			signal = arsta->rssi_beacon;
 10562	
 10563		if (signal) {
 10564			sinfo->signal = db2dbm ? signal : signal + ATH12K_DEFAULT_NOISE_FLOOR;
 10565			sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL);
 10566		}
 10567	
 10568		sinfo->signal_avg = ewma_avg_rssi_read(&arsta->avg_rssi);
 10569	
 10570		if (!db2dbm)
 10571			sinfo->signal_avg += ATH12K_DEFAULT_NOISE_FLOOR;
 10572	
 10573		sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL_AVG);
 10574	}
 10575	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki