Re: [Buildroot] [PATCH 5/9] package/libcamera: improve reproducibility for optional dependencies

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Quentin Schulz <foss+buildroot@0leil.net>
Cc: buildroot@buildroot.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [Buildroot] [PATCH 5/9] package/libcamera: improve reproducibility for optional dependencies
Date: Sat, 19 Apr 2025 22:27:29 +0200	[thread overview]
Message-ID: <20250419222729.4979f7e3@windsurf> (raw)
In-Reply-To: <20250404-libcamera-0-5-0-v1-5-e2ca9d029aeb@cherry.de>

On Fri, 04 Apr 2025 18:47:36 +0200
Quentin Schulz <foss+buildroot@0leil.net> wrote:

> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> libcamera has some optional dependencies that automatically detected at
> build time.
> 
> To improve reproducibility, we should add a dependency on those optional
> dependencies if the symbols that build them are enabled so that the
> order in which packages are built does not influence the libcamera
> package.
> 
> Note that the optional libyuv dependency isn't added as:
> 1) it is only used for the virtual pipeline and the android feature,
>    both of which are disabled/not supported right now,
> 2) libcamera has it in a submodule if missing (though if that works with
>    Buildroot is to be determined),
> 3) adding the dependency isn't enough as meson somehow doesn't find the
>    dependency,
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
>  package/libcamera/libcamera.mk | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot