From: Stephen Hemminger <stephen@networkplumber.org>
To: <kirankumark@marvell.com>
Cc: Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
<dev@dpdk.org>
Subject: Re: [PATCH] ethdev: add support for flow action pop E-tag
Date: Mon, 21 Apr 2025 07:51:01 -0700 [thread overview]
Message-ID: <20250421075101.58dffd0f@hermes.local> (raw)
In-Reply-To: <20250421115134.841719-1-kirankumark@marvell.com>
On Mon, 21 Apr 2025 17:21:34 +0530
<kirankumark@marvell.com> wrote:
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 998527590f..c4359e965d 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -652,6 +652,7 @@ enum index {
> ACTION_METER_STATE,
> ACTION_OF_DEC_NW_TTL,
> ACTION_OF_POP_VLAN,
> + ACTION_OF_POP_ETAG,
> ACTION_OF_PUSH_VLAN,
> ACTION_OF_PUSH_VLAN_ETHERTYPE,
> ACTION_OF_SET_VLAN_VID,
Putting it in the middle of VLAN stuff seems odd.
Maybe put these in alphabetical order.
next prev parent reply other threads:[~2025-04-21 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 11:51 [PATCH] ethdev: add support for flow action pop E-tag kirankumark
2025-04-21 14:51 ` Stephen Hemminger [this message]
2025-04-22 5:53 ` [PATCH v2] " kirankumark
2025-04-23 0:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421075101.58dffd0f@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=kirankumark@marvell.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.