From: Simon Horman <horms@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, brett.creeley@amd.com
Subject: Re: [PATCH v2 net-next 2/3] ionic: support ethtool get_module_eeprom_by_page
Date: Mon, 21 Apr 2025 11:54:28 +0100 [thread overview]
Message-ID: <20250421105428.GB2789685@horms.kernel.org> (raw)
In-Reply-To: <20250415231317.40616-3-shannon.nelson@amd.com>
On Tue, Apr 15, 2025 at 04:13:15PM -0700, Shannon Nelson wrote:
> Add support for the newer get_module_eeprom_by_page interface.
> Only the upper half of the 256 byte page is available for
> reading, and the firmware puts the two sections into the
> extended sprom buffer, so a union is used over the extended
> sprom buffer to make clear which page is to be accessed.
>
> With get_module_eeprom_by_page implemented there is no need
> for the older get_module_info or git_module_eeprom interfaces,
> so remove them.
>
> Reviewed-by: Brett Creeley <brett.creeley@amd.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-04-21 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 23:13 [PATCH v2 net-next 0/3] ionic: support QSFP CMIS Shannon Nelson
2025-04-15 23:13 ` [PATCH v2 net-next 1/3] ionic: extend the QSFP module sprom for more pages Shannon Nelson
2025-04-21 10:54 ` Simon Horman
2025-04-15 23:13 ` [PATCH v2 net-next 2/3] ionic: support ethtool get_module_eeprom_by_page Shannon Nelson
2025-04-21 10:54 ` Simon Horman [this message]
2025-04-15 23:13 ` [PATCH v2 net-next 3/3] ionic: add module eeprom channel data to ionic_if and ethtool Shannon Nelson
2025-04-21 10:54 ` Simon Horman
2025-04-22 10:40 ` [PATCH v2 net-next 0/3] ionic: support QSFP CMIS patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421105428.GB2789685@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.