From: kernel test robot <lkp@intel.com>
To: Troy Mitchell <troymitchell988@gmail.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Andi Shyti <andi.shyti@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-i2c@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Troy Mitchell <troymitchell988@gmail.com>,
Yongchao Jia <jyc0019@gmail.com>
Subject: Re: [PATCH 1/2] i2c: imx: use guard to take spinlock
Date: Mon, 21 Apr 2025 15:28:48 +0800 [thread overview]
Message-ID: <202504211501.MNwGdl5F-lkp@intel.com> (raw)
In-Reply-To: <20250421-i2c-imx-update-v1-1-1137f1f353d5@gmail.com>
Hi Troy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 9d7a0577c9db35c4cc52db90bc415ea248446472]
url: https://github.com/intel-lab-lkp/linux/commits/Troy-Mitchell/i2c-imx-use-guard-to-take-spinlock/20250421-133753
base: 9d7a0577c9db35c4cc52db90bc415ea248446472
patch link: https://lore.kernel.org/r/20250421-i2c-imx-update-v1-1-1137f1f353d5%40gmail.com
patch subject: [PATCH 1/2] i2c: imx: use guard to take spinlock
config: hexagon-randconfig-001-20250421 (https://download.01.org/0day-ci/archive/20250421/202504211501.MNwGdl5F-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250421/202504211501.MNwGdl5F-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504211501.MNwGdl5F-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/i2c/busses/i2c-imx.c:1140:17: warning: unused variable 'ret' [-Wunused-variable]
irqreturn_t ret;
^
1 warning generated.
vim +/ret +1140 drivers/i2c/busses/i2c-imx.c
aa11e38ce6fe88 Darius Augulis 2009-01-30 1124
f7414cd6923fd7 Biwen Li 2020-11-11 1125 static irqreturn_t i2c_imx_isr(int irq, void *dev_id)
f7414cd6923fd7 Biwen Li 2020-11-11 1126 {
f7414cd6923fd7 Biwen Li 2020-11-11 1127 struct imx_i2c_struct *i2c_imx = dev_id;
f7414cd6923fd7 Biwen Li 2020-11-11 1128 unsigned int ctl, status;
f7414cd6923fd7 Biwen Li 2020-11-11 1129
d3973a577b8e10 Troy Mitchell 2025-04-21 1130 guard(spinlock_irqsave)(&i2c_imx->slave_lock);
d3973a577b8e10 Troy Mitchell 2025-04-21 1131
f7414cd6923fd7 Biwen Li 2020-11-11 1132 status = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR);
f7414cd6923fd7 Biwen Li 2020-11-11 1133 ctl = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR);
05ae60bc24f765 Kevin Paul Herbert 2020-12-22 1134
f7414cd6923fd7 Biwen Li 2020-11-11 1135 if (status & I2SR_IIF) {
f7414cd6923fd7 Biwen Li 2020-11-11 1136 i2c_imx_clear_irq(i2c_imx, I2SR_IIF);
d3973a577b8e10 Troy Mitchell 2025-04-21 1137
05ae60bc24f765 Kevin Paul Herbert 2020-12-22 1138 if (i2c_imx->slave) {
05ae60bc24f765 Kevin Paul Herbert 2020-12-22 1139 if (!(ctl & I2CR_MSTA)) {
f89bf95632b416 Corey Minyard 2021-11-12 @1140 irqreturn_t ret;
f89bf95632b416 Corey Minyard 2021-11-12 1141
d3973a577b8e10 Troy Mitchell 2025-04-21 1142 return i2c_imx_slave_handle(i2c_imx,
f89bf95632b416 Corey Minyard 2021-11-12 1143 status, ctl);
05ae60bc24f765 Kevin Paul Herbert 2020-12-22 1144 }
f89bf95632b416 Corey Minyard 2021-11-12 1145 i2c_imx_slave_finish_op(i2c_imx);
05ae60bc24f765 Kevin Paul Herbert 2020-12-22 1146 }
d3973a577b8e10 Troy Mitchell 2025-04-21 1147
f7414cd6923fd7 Biwen Li 2020-11-11 1148 return i2c_imx_master_isr(i2c_imx, status);
f7414cd6923fd7 Biwen Li 2020-11-11 1149 }
f7414cd6923fd7 Biwen Li 2020-11-11 1150
aa11e38ce6fe88 Darius Augulis 2009-01-30 1151 return IRQ_NONE;
aa11e38ce6fe88 Darius Augulis 2009-01-30 1152 }
aa11e38ce6fe88 Darius Augulis 2009-01-30 1153
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-04-21 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 5:36 [PATCH 0/2] i2c: imx: adapting the mainline Troy Mitchell
2025-04-21 5:36 ` [PATCH 1/2] i2c: imx: use guard to take spinlock Troy Mitchell
2025-04-21 7:28 ` kernel test robot [this message]
2025-04-21 18:05 ` Frank Li
2025-04-22 15:12 ` Jonathan Cameron
2025-04-22 15:26 ` Troy Mitchell
2025-04-22 15:53 ` Ahmad Fatoum
2025-04-22 16:05 ` Ahmad Fatoum
2025-04-21 5:36 ` [PATCH 2/2] i2c: imx: drop master prefix Troy Mitchell
2025-04-22 16:10 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504211501.MNwGdl5F-lkp@intel.com \
--to=lkp@intel.com \
--cc=andi.shyti@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jyc0019@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=o.rempel@pengutronix.de \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.