All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Rajendra Nayak <quic_rjendra@quicinc.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 4/5] arm64: dts: qcom: ipq5424: drop the fallback WDT compatible
Date: Mon, 21 Apr 2025 14:44:03 -0500	[thread overview]
Message-ID: <20250421194403.GB2648051-robh@kernel.org> (raw)
In-Reply-To: <20250416-wdt_reset_reason-v2-4-c65bba312914@oss.qualcomm.com>

On Wed, Apr 16, 2025 at 01:59:21PM +0530, Kathiravan Thirumoorthy wrote:
> To retrieve the restart reason from IMEM, certain device specific data
> to be used. To achieve that, drop the fallback compatible.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
> Changes in v2:
> 	- New Patch
> ---
>  arch/arm64/boot/dts/qcom/ipq5424.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Just so it is abundantly clear. NAK.

See my reply on the binding patch.

> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> index 4f18ea79502738c2b9cb4b13e8eb4ac4ddd89adf..21252352b7328e4a1b7ba6ca7080f73722f097ad 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> @@ -376,7 +376,7 @@ intc: interrupt-controller@f200000 {
>  		};
>  
>  		watchdog@f410000 {
> -			compatible = "qcom,apss-wdt-ipq5424", "qcom,kpss-wdt";
> +			compatible = "qcom,apss-wdt-ipq5424";
>  			reg = <0 0x0f410000 0 0x1000>;
>  			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
>  			clocks = <&sleep_clk>;
> 
> -- 
> 2.34.1
> 

  reply	other threads:[~2025-04-21 19:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16  8:29 [PATCH v2 0/5] Add support to read the restart reason from IMEM Kathiravan Thirumoorthy
2025-04-16  8:29 ` [PATCH v2 1/5] dt-bindings: sram: qcom,imem: Document IPQ5424 compatible Kathiravan Thirumoorthy
2025-04-21 19:12   ` Rob Herring (Arm)
2025-04-16  8:29 ` [PATCH v2 2/5] arm64: dts: qcom: ipq5424: Add the IMEM node Kathiravan Thirumoorthy
2025-04-16 14:52   ` Konrad Dybcio
2025-04-16  8:29 ` [PATCH v2 3/5] dt-bindings: watchdog: separate out the IPQ5424 compatilble Kathiravan Thirumoorthy
2025-04-21 19:43   ` Rob Herring
2025-04-28  4:02     ` Kathiravan Thirumoorthy
2025-04-16  8:29 ` [PATCH v2 4/5] arm64: dts: qcom: ipq5424: drop the fallback WDT compatible Kathiravan Thirumoorthy
2025-04-21 19:44   ` Rob Herring [this message]
2025-04-16  8:29 ` [PATCH v2 5/5] watchdog: qcom: add support to read the restart reason from IMEM Kathiravan Thirumoorthy
2025-04-16 14:51   ` Konrad Dybcio
2025-04-17  6:19     ` Kathiravan Thirumoorthy
2025-04-30 14:28       ` Konrad Dybcio
2025-04-30 14:58         ` Kathiravan Thirumoorthy
2025-05-01  0:01   ` Bryan O'Donoghue
2025-05-02  4:42     ` Kathiravan Thirumoorthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250421194403.GB2648051-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=quic_rjendra@quicinc.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.