From: steven chen <chenste@linux.microsoft.com>
To: zohar@linux.ibm.com, stefanb@linux.ibm.com,
roberto.sassu@huaweicloud.com, roberto.sassu@huawei.com,
eric.snowberg@oracle.com, ebiederm@xmission.com,
paul@paul-moore.com, code@tyhicks.com, bauermann@kolabnow.com,
linux-integrity@vger.kernel.org, kexec@lists.infradead.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: madvenka@linux.microsoft.com, nramas@linux.microsoft.com,
James.Bottomley@HansenPartnership.com, bhe@redhat.com,
vgoyal@redhat.com, dyoung@redhat.com
Subject: [PATCH v13 7/9] ima: verify if the segment size has changed
Date: Mon, 21 Apr 2025 15:25:13 -0700 [thread overview]
Message-ID: <20250421222516.9830-8-chenste@linux.microsoft.com> (raw)
In-Reply-To: <20250421222516.9830-1-chenste@linux.microsoft.com>
From: Steven Chen <chenste@linux.microsoft.com>
kexec 'load' may be called multiple times. Free and realloc the buffer
only if the segment_size is changed from the previous kexec 'load' call.
Signed-off-by: Steven Chen <chenste@linux.microsoft.com>
Acked-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
---
security/integrity/ima/ima_kexec.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c
index 5c3b3e0b2186..ed867734ee70 100644
--- a/security/integrity/ima/ima_kexec.c
+++ b/security/integrity/ima/ima_kexec.c
@@ -33,6 +33,14 @@ static void ima_free_kexec_file_buf(struct seq_file *sf)
static int ima_alloc_kexec_file_buf(size_t segment_size)
{
+ /*
+ * kexec 'load' may be called multiple times.
+ * Free and realloc the buffer only if the segment_size is
+ * changed from the previous kexec 'load' call.
+ */
+ if (ima_kexec_file.buf && ima_kexec_file.size == segment_size)
+ goto out;
+
ima_free_kexec_file_buf(&ima_kexec_file);
/* segment size can't change between kexec load and execute */
@@ -41,6 +49,8 @@ static int ima_alloc_kexec_file_buf(size_t segment_size)
return -ENOMEM;
ima_kexec_file.size = segment_size;
+
+out:
ima_kexec_file.read_pos = 0;
ima_kexec_file.count = sizeof(struct ima_kexec_hdr); /* reserved space */
--
2.43.0
next prev parent reply other threads:[~2025-04-21 22:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 22:25 [PATCH v13 0/9] ima: kexec: measure events between kexec load and execute steven chen
2025-04-21 22:25 ` [PATCH v13 1/9] ima: rename variable the seq_file "file" to "ima_kexec_file" steven chen
2025-04-21 22:25 ` [PATCH v13 2/9] ima: define and call ima_alloc_kexec_file_buf() steven chen
2025-04-29 18:30 ` Stefan Berger
2025-04-21 22:25 ` [PATCH v13 3/9] kexec: define functions to map and unmap segments steven chen
2025-04-23 0:29 ` Mimi Zohar
2025-04-23 15:29 ` steven chen
2025-04-23 18:21 ` Mimi Zohar
2025-04-21 22:25 ` [PATCH v13 4/9] ima: kexec: skip IMA segment validation after kexec soft reboot steven chen
2025-04-21 22:25 ` [PATCH v13 5/9] ima: kexec: define functions to copy IMA log at soft boot steven chen
2025-04-29 16:50 ` Stefan Berger
2025-04-21 22:25 ` [PATCH v13 6/9] ima: kexec: move IMA log copy from kexec load to execute steven chen
2025-04-21 22:25 ` steven chen [this message]
2025-04-29 18:19 ` [PATCH v13 7/9] ima: verify if the segment size has changed Stefan Berger
2025-04-21 22:25 ` [PATCH v13 8/9] ima: make the kexec extra memory configurable steven chen
2025-04-29 19:06 ` Stefan Berger
2025-04-29 22:00 ` steven chen
2025-04-21 22:25 ` [PATCH v13 9/9] ima: measure kexec load and exec events as critical data steven chen
2025-04-29 18:18 ` Stefan Berger
2025-04-24 14:37 ` [PATCH v13 0/9] ima: kexec: measure events between kexec load and execute Baoquan He
2025-04-24 19:26 ` steven chen
2025-05-02 16:25 ` steven chen
2025-05-06 5:49 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421222516.9830-8-chenste@linux.microsoft.com \
--to=chenste@linux.microsoft.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bauermann@kolabnow.com \
--cc=bhe@redhat.com \
--cc=code@tyhicks.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.snowberg@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=madvenka@linux.microsoft.com \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=stefanb@linux.ibm.com \
--cc=vgoyal@redhat.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.