All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Guillaume Chaye <guillaume.chaye@zeetim.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/cjson: add a patch to cross-compile projects that rely on cjson.
Date: Mon, 21 Apr 2025 23:38:16 +0200	[thread overview]
Message-ID: <20250421233816.05d28323@windsurf> (raw)
In-Reply-To: <20250325102111.155721-1-guillaume.chaye@zeetim.com>

Hello Guillaume,

On Tue, 25 Mar 2025 06:21:11 -0400
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:

> From: "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com>
> 
> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
> Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>

Thanks Guillaume. However, your commit log is empty, and it's not clear
what this patch is doing. What it is bringing or fixing?

> diff --git a/package/cjson/0001-Use-CMakePackageConfigHelpers-to-generate-config.cmake.patch b/package/cjson/0001-Use-CMakePackageConfigHelpers-to-generate-config.cmake.patch
> new file mode 100644
> index 0000000000..04248afbd9
> --- /dev/null
> +++ b/package/cjson/0001-Use-CMakePackageConfigHelpers-to-generate-config.cmake.patch
> @@ -0,0 +1,191 @@
> +From 2b0a994b5832439cf704147c5b485b9a4c7fbc24 Mon Sep 17 00:00:00 2001
> +From: Charles Chan <charles@zeerd.com>
> +Date: Fri, 22 Dec 2023 11:14:36 +0800
> +Subject: [PATCH] Use CMakePackageConfigHelpers to generate config.cmake
> +Signed-off-by: Charles Chan <charles@zeerd.com>
> +Upstream: https://github.com/DaveGamble/cJSON/pull/812/commits/2b0a994b5832439cf704147c5b485b9a4c7fbc24

When you add a patch, you need to add your Signed-off-by to the patch.
But really, we need more details on why this patch would be needed.

Before sending a patch, ask yourself the question: "do I provide enough
details to allow the maintainers who will review my patch to understand
why my patch is needed, and what it is doing". This will *tremendously*
help your patches in getting merged.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-04-21 21:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 10:21 [Buildroot] [PATCH 1/1] package/cjson: add a patch to cross-compile projects that rely on cjson Guillaume Chaye
2025-04-21 21:38 ` Thomas Petazzoni via buildroot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-20 15:59 Guillaume GC. Chaye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250421233816.05d28323@windsurf \
    --to=buildroot@buildroot.org \
    --cc=guillaume.chaye@zeetim.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.