From: Christoph Hellwig <hch@lst.de>
To: Leon Romanovsky <leon@kernel.org>
Cc: "Marek Szyprowski" <m.szyprowski@samsung.com>,
"Jens Axboe" <axboe@kernel.dk>, "Christoph Hellwig" <hch@lst.de>,
"Keith Busch" <kbusch@kernel.org>,
"Kanchan Joshi" <joshi.k@samsung.com>, "Jake Edge" <jake@lwn.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Zhu Yanjun" <zyjzyj2000@gmail.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Yishai Hadas" <yishaih@nvidia.com>,
"Shameer Kolothum" <shameerali.kolothum.thodi@huawei.com>,
"Kevin Tian" <kevin.tian@intel.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
iommu@lists.linux.dev, linux-nvme@lists.infradead.org,
linux-pci@vger.kernel.org, kvm@vger.kernel.org,
linux-mm@kvack.org, "Niklas Schnelle" <schnelle@linux.ibm.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Matthew Wilcox" <willy@infradead.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Chaitanya Kulkarni" <kch@nvidia.com>,
"Nitesh Shetty" <nj.shetty@samsung.com>,
"Leon Romanovsky" <leonro@nvidia.com>
Subject: Re: [PATCH v8 24/24] nvme-pci: optimize single-segment handling
Date: Tue, 22 Apr 2025 06:39:56 +0200 [thread overview]
Message-ID: <20250422043955.GA28077@lst.de> (raw)
In-Reply-To: <670389227a033bd5b7c5aa55191aac9943244028.1744825142.git.leon@kernel.org>
On Fri, Apr 18, 2025 at 09:47:54AM +0300, Leon Romanovsky wrote:
> From: Kanchan Joshi <joshi.k@samsung.com>
>
> blk_rq_dma_map API is costly for single-segment requests.
> Avoid using it and map the bio_vec directly.
This needs to be folded into the earlier patches or split prep patches
instead of undoing work done earlier, preferably combined with a bit
of code movement so that the new nvme_try_setup_prp_simple stays in
the same place as before and the diff shows it reusing code.
E.g. change
"nvme-pci: use a better encoding for small prp pool allocations" to
already use the flags instead of my boolean, and maybe include
abort in the flags instead of using a separate bool so that we
don't increase hte iod size.
Slot in a new patch after that that dropping the single SGL segment
fastpath if we think we don't need that, although if we need the PRP
one I suspect that one would still be very helpful as well.
Add a patch if we want the try_ version of, although when keeping
the optimization for SGLs as well that are will look a bit different.
I'm happy to give away my patch authorship credits if that helps with
the folding.
next prev parent reply other threads:[~2025-04-22 4:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 6:47 [PATCH v8 00/24] Provide a new two step DMA mapping API Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 01/24] PCI/P2PDMA: Refactor the p2pdma mapping helpers Leon Romanovsky
2025-04-20 20:05 ` ALOK TIWARI
2025-04-18 6:47 ` [PATCH v8 02/24] dma-mapping: move the PCI P2PDMA mapping helpers to pci-p2pdma.h Leon Romanovsky
2025-04-20 20:09 ` ALOK TIWARI
2025-04-18 6:47 ` [PATCH v8 03/24] iommu: generalize the batched sync after map interface Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 04/24] iommu: add kernel-doc for iommu_unmap and iommu_unmap_fast Leon Romanovsky
2025-04-22 4:23 ` Christoph Hellwig
2025-04-22 6:27 ` Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 05/24] dma-mapping: Provide an interface to allow allocate IOVA Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 06/24] iommu/dma: Factor out a iommu_dma_map_swiotlb helper Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 07/24] dma-mapping: Implement link/unlink ranges API Leon Romanovsky
2025-04-20 20:23 ` ALOK TIWARI
2025-04-18 6:47 ` [PATCH v8 08/24] dma-mapping: add a dma_need_unmap helper Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 09/24] docs: core-api: document the IOVA-based API Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 10/24] mm/hmm: let users to tag specific PFN with DMA mapped bit Leon Romanovsky
2025-04-22 4:24 ` Christoph Hellwig
2025-04-18 6:47 ` [PATCH v8 11/24] mm/hmm: provide generic DMA managing logic Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 12/24] RDMA/umem: Store ODP access mask information in PFN Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 13/24] RDMA/core: Convert UMEM ODP DMA mapping to caching IOVA and page linkage Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 14/24] RDMA/umem: Separate implicit ODP initialization from explicit ODP Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 15/24] vfio/mlx5: Explicitly use number of pages instead of allocated length Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 16/24] vfio/mlx5: Rewrite create mkey flow to allow better code reuse Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 17/24] vfio/mlx5: Enable the DMA link API Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 18/24] block: share more code for bio addition helper Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 19/24] block: don't merge different kinds of P2P transfers in a single bio Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 20/24] blk-mq: add scatterlist-less DMA mapping helpers Leon Romanovsky
2025-04-18 18:03 ` ALOK TIWARI
2025-04-20 7:09 ` Leon Romanovsky
2025-04-22 4:27 ` Christoph Hellwig
2025-04-22 6:36 ` Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 21/24] nvme-pci: remove struct nvme_descriptor Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 22/24] nvme-pci: use a better encoding for small prp pool allocations Leon Romanovsky
2025-04-18 6:47 ` [PATCH v8 23/24] nvme-pci: convert to blk_rq_dma_map Leon Romanovsky
2025-04-18 18:29 ` ALOK TIWARI
2025-04-22 5:00 ` Christoph Hellwig
2025-04-22 7:26 ` Leon Romanovsky
2025-04-22 7:32 ` Christoph Hellwig
2025-04-18 6:47 ` [PATCH v8 24/24] nvme-pci: optimize single-segment handling Leon Romanovsky
2025-04-18 8:02 ` Damien Le Moal
2025-04-18 11:19 ` Leon Romanovsky
2025-04-18 12:32 ` Kanchan Joshi
2025-04-22 4:39 ` Christoph Hellwig [this message]
2025-04-22 7:44 ` Leon Romanovsky
2025-04-22 11:36 ` Leon Romanovsky
2025-04-18 11:16 ` [PATCH v8 00/24] Provide a new two step DMA mapping API Leon Romanovsky
2025-04-18 12:18 ` Jens Axboe
2025-04-20 7:14 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422043955.GA28077@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=chuck.lever@oracle.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=iommu@lists.linux.dev \
--cc=jake@lwn.net \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=joro@8bytes.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=m.szyprowski@samsung.com \
--cc=mcgrof@kernel.org \
--cc=nj.shetty@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sagi@grimberg.me \
--cc=schnelle@linux.ibm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.