From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: song@kernel.org, yukuai3@huawei.com, linux-raid@vger.kernel.org,
hch@lst.de, willy@infradead.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH-RFC] md-bitmap: use page cache for file backed
Date: Tue, 22 Apr 2025 08:24:52 +0200 [thread overview]
Message-ID: <20250422062452.GA30127@lst.de> (raw)
In-Reply-To: <20250418015636.2457376-1-kbusch@meta.com>
On Thu, Apr 17, 2025 at 06:56:36PM -0700, Keith Busch wrote:
> The md bitmap file had been using a custom page and buffer_head mapping,
> going around the filesystem. Use pages from the file's page cache
> instead, removing the abused buffer_head and bmap usage.
>
> For file backed bitmaps, pages are initialized with read_mapping_page
> instead of allocating special pages. This returns pages synced with the
> backing file. Persisting changes just needs to set the dirty pages and
> initiate a write back as needed.
Using the page cache all the way down in the I/O stack introduces a
significant deadlock potential as we can't use mempool for it.
See the discussion related to Yu Kuai's lockless bitmap series. Reading
the cover letter for that it is intended to be on-disk compatible to
the existing bitmap, so maybe we should concentrate on the new version
of that instead of having to parallel bitmap efforts?
prev parent reply other threads:[~2025-04-22 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 1:56 [PATCH-RFC] md-bitmap: use page cache for file backed Keith Busch
2025-04-22 6:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422062452.GA30127@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=willy@infradead.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.