From: hch <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: hch <hch@lst.de>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"djwong@kernel.org" <djwong@kernel.org>,
"ebiggers@google.com" <ebiggers@google.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] fs: move the bdex_statx call to vfs_getattr_nosec
Date: Tue, 22 Apr 2025 10:17:36 +0200 [thread overview]
Message-ID: <20250422081736.GA674@lst.de> (raw)
In-Reply-To: <20250422-angepackt-reisen-bc24fbec2702@brauner>
On Tue, Apr 22, 2025 at 10:15:48AM +0200, Christian Brauner wrote:
> > - bdev = blkdev_get_no_open(backing_inode->i_rdev);
> > + if (!(request_mask & (STATX_DIOALIGN | STATX_WRITE_ATOMIC)))
> > + return;
>
> This leaks the block device reference if blkdev_get_no_open() succeeds.
>
> > +
> > + bdev = blkdev_get_no_open(d_backing_inode(path->dentry)->i_rdev);
The one removed by the patch above, or the one added after the check
below? :)
next prev parent reply other threads:[~2025-04-22 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 6:40 [PATCH] fs: move the bdex_statx call to vfs_getattr_nosec Christoph Hellwig
2025-04-17 8:01 ` Christian Brauner
2025-04-17 8:14 ` Christian Brauner
2025-04-17 16:20 ` Darrick J. Wong
2025-04-22 5:03 ` Shinichiro Kawasaki
2025-04-22 5:51 ` hch
2025-04-22 7:25 ` Christian Brauner
2025-04-22 7:27 ` hch
2025-04-22 8:15 ` Christian Brauner
2025-04-22 8:17 ` hch [this message]
2025-04-22 9:29 ` Christian Brauner
2025-04-22 14:15 ` hch
2025-04-22 15:35 ` Christian Brauner
2025-04-23 1:31 ` Shinichiro Kawasaki
2025-04-23 4:30 ` Jain, Ayush
2025-04-22 10:31 ` Shinichiro Kawasaki
2025-04-22 14:18 ` Heiko Carstens
[not found] ` <d6dc234d922d8beda65f2a1eed1e2de6a50c978f.camel@linux.ibm.com>
2025-04-25 13:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422081736.GA674@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=ebiggers@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.