All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: [REGRESSION] [PATCH 1/1] mtd: mtdpart: Support MTD_SIZE_REMAINING with unallocated memory area
Date: Tue, 22 Apr 2025 12:37:32 +0200	[thread overview]
Message-ID: <20250422103732.GA117260@francesco-nb> (raw)
In-Reply-To: <20250220145808.1911832-1-alexander.stein@ew.tq-group.com>

Hello Tom, Alexander

On Thu, Feb 20, 2025 at 03:58:07PM +0100, Alexander Stein wrote:
> If there is an unallocated memory area before the last, filling parting
> the size calculation for MTD_SIZE_REMAINING does not take this hole
> into account.
> Fix this by calculating the remaining size just based on total size
> and partition offset.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

This change introduced a regression on colibri imx7 and imx6ull.

```
Booting from NAND...
Partition size must be a multiple of 2048
Could not parse device nand0
Failed parsing MTD partitions from mtdparts!
Partition ubi not found!
```

Reverting commit 1ca97ee90392 ("mtd: mtdpart: Support MTD_SIZE_REMAINING
with unallocated memory area") on top of current master fixes the issue.

Any suggestion? I have not looked at the code, I just did a git bisect.

Francesco


  parent reply	other threads:[~2025-04-22 10:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 14:58 [PATCH 1/1] mtd: mtdpart: Support MTD_SIZE_REMAINING with unallocated memory area Alexander Stein
2025-02-28 20:23 ` Tom Rini
2025-04-22 10:37 ` Francesco Dolcini [this message]
2025-04-22 13:05   ` [REGRESSION] " Alexander Stein
2025-04-22 13:07     ` Francesco Dolcini
2025-04-25  3:31       ` Weijie Gao (高惟杰)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422103732.GA117260@francesco-nb \
    --to=francesco@dolcini.it \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.