From: Rob Herring <robh@kernel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
Cc: Nitin Rawat <quic_nitirawa@quicinc.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
krzk+dt@kernel.org, mani@kernel.org, conor+dt@kernel.org,
James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, beanhuo@micron.com,
peter.wang@mediatek.com, linux-arm-msm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V1 2/3] scsi: ufs: pltfrm: Add parsing support for disable LPM property
Date: Tue, 22 Apr 2025 07:38:42 -0500 [thread overview]
Message-ID: <20250422123842.GA896279-robh@kernel.org> (raw)
In-Reply-To: <0a121c0f-edcb-4d5d-8427-f1eddddcb9bc@quicinc.com>
On Fri, Apr 18, 2025 at 10:13:46AM +0530, Mukesh Kumar Savaliya wrote:
>
>
> On 4/17/2025 6:16 PM, Nitin Rawat wrote:
> [...]
> > +/**
> > + * ufshcd_parse_lpm_support - read from DT whether LPM modes should be disabled.
> > + * @hba: host controller instance
> > + */
> > +static void ufshcd_parse_lpm_support(struct ufs_hba *hba)
> > +{
> > + struct device *dev = hba->dev;
> > +
> > + hba->disable_lpm = of_property_read_bool(dev->of_node, "disable-lpm");
> > + if (hba->disable_lpm)
> > + dev_info(hba->dev, "UFS LPM is disabled\n");
> How about keeping as debug ?
Why print it at all. You can just read the DT from userspace.
Rob
next prev parent reply other threads:[~2025-04-22 12:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 12:46 [PATCH V1 0/3] Add support to disable UFS LPM Nitin Rawat
2025-04-17 12:46 ` [PATCH V1 1/3] scsi: ufs: dt-bindings: Document UFS Disable LPM property Nitin Rawat
2025-04-17 12:46 ` [PATCH V1 2/3] scsi: ufs: pltfrm: Add parsing support for disable " Nitin Rawat
2025-04-18 4:43 ` Mukesh Kumar Savaliya
2025-04-22 12:38 ` Rob Herring [this message]
2025-04-17 12:46 ` [PATCH V1 3/3] scsi: ufs: qcom: Add support to disable UFS LPM Feature Nitin Rawat
2025-04-22 12:45 ` Rob Herring
2025-04-22 19:44 ` Nitin Rawat
2025-04-23 13:56 ` Rob Herring
2025-04-25 20:22 ` Nitin Rawat
2025-04-23 5:00 ` Peter Wang (王信友)
2025-04-23 6:24 ` Nitin Rawat
2025-04-17 21:36 ` [PATCH V1 0/3] Add support to disable UFS LPM Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422123842.GA896279-robh@kernel.org \
--to=robh@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.