All of lore.kernel.org
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.ibm.com>
To: mpe@ellerman.id.au, christophe.leroy@csgroup.eu
Cc: npiggin@gmail.com, naveen@kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	Madhavan Srinivasan <maddy@linux.ibm.com>
Subject: [PATCH 3/6] powerpc/perf:make isa207_pmu_format_group struct static
Date: Tue, 22 Apr 2025 18:40:37 +0530	[thread overview]
Message-ID: <20250422131040.374427-4-maddy@linux.ibm.com> (raw)
In-Reply-To: <20250422131040.374427-1-maddy@linux.ibm.com>

isa207_pmu_format_group struct is local to the source and does not need to
be in global scope, so make it static

Cleans up sparse warning:
arch/powerpc/perf/isa207-common.c:40:30: warning: symbol 'isa207_pmu_format_group'
was not declared. Should it be static?

Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
---
 arch/powerpc/perf/isa207-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/perf/isa207-common.c b/arch/powerpc/perf/isa207-common.c
index 2b3547fdba4a..bbef51849f33 100644
--- a/arch/powerpc/perf/isa207-common.c
+++ b/arch/powerpc/perf/isa207-common.c
@@ -37,7 +37,7 @@ static struct attribute *isa207_pmu_format_attr[] = {
 	NULL,
 };
 
-const struct attribute_group isa207_pmu_format_group = {
+static const struct attribute_group isa207_pmu_format_group = {
 	.name = "format",
 	.attrs = isa207_pmu_format_attr,
 };
-- 
2.49.0



  parent reply	other threads:[~2025-04-22 13:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 13:10 [PATCH 0/6] Fixes for shellcheck/sparse warnings Madhavan Srinivasan
2025-04-22 13:10 ` [PATCH 1/6] powerpc/kvm: Fix sparse warning Madhavan Srinivasan
2025-04-22 13:10 ` [PATCH 2/6] powerpc/xmon: fix sparse warning "Using plain integer as NULL pointer" Madhavan Srinivasan
2025-05-02 10:08   ` Christophe Leroy
2025-05-18  3:51     ` Madhavan Srinivasan
2025-04-22 13:10 ` Madhavan Srinivasan [this message]
2025-05-07 11:52   ` [PATCH 3/6] powerpc/perf:make isa207_pmu_format_group struct static kernel test robot
2025-04-22 13:10 ` [PATCH 4/6] powerpc: fix sparse warnings Madhavan Srinivasan
2025-05-02 10:16   ` Christophe Leroy
2025-05-18  3:54     ` Madhavan Srinivasan
2025-05-07 11:11   ` kernel test robot
2025-04-22 13:10 ` [PATCH 5/6] powerpc/prom_init: Fix shellcheck warnings Madhavan Srinivasan
2025-04-22 13:42   ` Stephen Rothwell
2025-04-22 13:10 ` [PATCH 6/6] powerpc/boot/install.sh: " Madhavan Srinivasan
2025-04-22 13:46   ` Stephen Rothwell
2025-04-23  8:44 ` [PATCH 0/6] Fixes for shellcheck/sparse warnings Venkat Rao Bagalkote

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422131040.374427-4-maddy@linux.ibm.com \
    --to=maddy@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen@kernel.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.