All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Johan Hovold <johan+linaro@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jeff Johnson <jjohnson@kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Jonas Gorski <jonas.gorski@gmail.com>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	ath11k@lists.infradead.org, ath12k@lists.infradead.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] PCI/arm64/ath11k/ath12k: Rename pwrctrl Kconfig symbols
Date: Tue, 22 Apr 2025 11:09:25 -0500	[thread overview]
Message-ID: <20250422160925.GA331992@bhelgaas> (raw)
In-Reply-To: <20250402132634.18065-1-johan+linaro@kernel.org>

[cc->to Catalin, Will: note the arm64 Kconfig change; my understanding
is that this shouldn't break existing configs]

On Wed, Apr 02, 2025 at 03:26:30PM +0200, Johan Hovold wrote:
> The PCI pwrctrl framework was renamed after being merged, but the
> Kconfig symbols still reflect the old name ("pwrctl" without an "r").
> 
> This leads to people not knowing how to refer to the framework in
> writing, inconsistencies in module naming, etc.
> 
> Let's rename also the Kconfig symbols before this gets any worse.
> 
> The ath11k, ath12k and arm64 changes could go theoretically go through
> the corresponding subsystem trees in turn once they have the new
> symbols, but to avoid tracking dependencies over multiple cycles it is
> much preferred to have all of these go in through the PCI tree.
> 
> The wifi patches have been acked by Jeff and I don't think Will or
> Catalin will mind the single rename in arm64 if they don't see this
> message in time.
> 
> Note that the patches could be squashed into one, but keeping them
> separate highlights the changes done to other subsystems. I also find it
> easier to review the changes this way.
> 
> There are some new pwrctrl drivers and an arm64 defconfig change on the
> lists, but the former should also go in through PCI anyway while we can
> make sure that the defconfig update matches the new slot symbol.
> 
> Note that getting this rename into rc1 would be great as that way it
> would end up in most subsystem trees soon as well.
> 
> Johan
> 
> 
> Changes in v2:
>  - drop deprecated symbol for the new slot driver to avoid having to a
>    add a new user visible symbol (e.g. any early adopters will be asked
>    to enable the renamed option again)
> 
>  - move arm64 patch last two avoid temporarily not having the pwrseq
>    driver selected (Jonas)
> 
> Johan Hovold (4):
>   PCI/pwrctrl: Rename pwrctrl Kconfig symbols and slot module
>   wifi: ath11k: switch to PCI_PWRCTRL_PWRSEQ
>   wifi: ath12k: switch to PCI_PWRCTRL_PWRSEQ
>   arm64: Kconfig: switch to HAVE_PWRCTRL
> 
>  arch/arm64/Kconfig.platforms            |  2 +-
>  drivers/net/wireless/ath/ath11k/Kconfig |  2 +-
>  drivers/net/wireless/ath/ath12k/Kconfig |  2 +-
>  drivers/pci/pwrctrl/Kconfig             | 22 ++++++++++++++++------
>  drivers/pci/pwrctrl/Makefile            |  8 ++++----
>  5 files changed, 23 insertions(+), 13 deletions(-)

Applied to pci/pwrctrl for v6.16, thanks!



      parent reply	other threads:[~2025-04-22 18:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02 13:26 [PATCH v2 0/4] PCI/arm64/ath11k/ath12k: Rename pwrctrl Kconfig symbols Johan Hovold
2025-04-02 13:26 ` [PATCH v2 1/4] PCI/pwrctrl: Rename pwrctrl Kconfig symbols and slot module Johan Hovold
2025-04-02 13:26 ` [PATCH v2 2/4] wifi: ath11k: switch to PCI_PWRCTRL_PWRSEQ Johan Hovold
2025-04-02 13:26 ` [PATCH v2 3/4] wifi: ath12k: " Johan Hovold
2025-04-02 13:26 ` [PATCH v2 4/4] arm64: Kconfig: switch to HAVE_PWRCTRL Johan Hovold
2025-04-02 13:32   ` Johan Hovold
2025-04-03  7:11 ` [PATCH v2 0/4] PCI/arm64/ath11k/ath12k: Rename pwrctrl Kconfig symbols Bartosz Golaszewski
2025-04-03  7:19   ` Johan Hovold
2025-04-03  7:38     ` Bartosz Golaszewski
2025-04-22 16:09 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422160925.GA331992@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=bhelgaas@google.com \
    --cc=brgl@bgdev.pl \
    --cc=catalin.marinas@arm.com \
    --cc=jjohnson@kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=jonas.gorski@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.