From: Jakub Kicinski <kuba@kernel.org>
To: Philipp Stanner <phasta@kernel.org>
Cc: Sunil Goutham <sgoutham@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Daniele Venzano <venza@brownhat.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Helge Deller <deller@gmx.de>, Ingo Molnar <mingo@kernel.org>,
Simon Horman <horms@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Sabrina Dubroca <sd@queasysnail.net>,
Jacob Keller <jacob.e.keller@intel.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [PATCH 2/8] net: octeontx2: Use pure PCI devres API
Date: Tue, 22 Apr 2025 17:49:14 -0700 [thread overview]
Message-ID: <20250422174914.43329f7f@kernel.org> (raw)
In-Reply-To: <20250416164407.127261-4-phasta@kernel.org>
On Wed, 16 Apr 2025 18:44:02 +0200 Philipp Stanner wrote:
> err_release_regions:
> pci_set_drvdata(pdev, NULL);
> - pci_release_regions(pdev);
This error path should be renamed. Could you also apply your conversion
to drivers/net/ethernet/marvell/octeontx2/af/ ?
--
pw-bot: cr
next prev parent reply other threads:[~2025-04-23 0:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 16:44 [PATCH 0/8] net: Phase out hybrid PCI devres API Philipp Stanner
2025-04-16 16:44 ` [PATCH 1/8] net: prestera: Use pure " Philipp Stanner
2025-04-16 16:44 ` [PATCH 2/8] net: octeontx2: " Philipp Stanner
2025-04-23 0:49 ` Jakub Kicinski [this message]
2025-04-23 6:28 ` Philipp Stanner
2025-04-23 8:38 ` Philipp Stanner
2025-04-23 22:14 ` Jakub Kicinski
2025-04-16 16:44 ` [PATCH 3/8] net: tulip: " Philipp Stanner
2025-04-16 16:44 ` [PATCH 4/8] net: ethernet: natsemi: " Philipp Stanner
2025-04-16 16:44 ` [PATCH 5/8] net: ethernet: sis900: " Philipp Stanner
2025-04-16 16:44 ` [PATCH 6/8] net: mdio: thunder: " Philipp Stanner
2025-04-16 16:44 ` [PATCH 7/8] net: thunder_bgx: " Philipp Stanner
2025-04-16 16:44 ` [PATCH 8/8] net: thunder_bgx: Don't disable PCI device manually Philipp Stanner
2025-04-16 17:10 ` [PATCH 0/8] net: Phase out hybrid PCI devres API Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422174914.43329f7f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkallweit1@gmail.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phasta@kernel.org \
--cc=sbhatta@marvell.com \
--cc=sd@queasysnail.net \
--cc=sgoutham@marvell.com \
--cc=taras.chornyi@plvision.eu \
--cc=tglx@linutronix.de \
--cc=venza@brownhat.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.