From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: bhelgaas@google.com, kw@linux.com,
Niklas Cassel <cassel@kernel.org>, Frank Li <Frank.Li@nxp.com>,
linux-pci@vger.kernel.org,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Subject: Re: [PATCH RESEND] misc: pci_endpoint_test: Defer IRQ allocation until ioctl(PCITEST_SET_IRQTYPE)
Date: Tue, 22 Apr 2025 12:53:19 -0500 [thread overview]
Message-ID: <20250422175319.GA373387@bhelgaas> (raw)
In-Reply-To: <174512170695.5723.16265162524139108187.b4-ty@linaro.org>
On Sun, Apr 20, 2025 at 09:31:46AM +0530, Manivannan Sadhasivam wrote:
> On Wed, 16 Apr 2025 16:28:26 +0200, Niklas Cassel wrote:
> > Commit a402006d48a9 ("misc: pci_endpoint_test: Remove global 'irq_type'
> > and 'no_msi'") changed so that the default IRQ vector requested by
> > pci_endpoint_test_probe() was no longer the module param 'irq_type',
> > but instead test->irq_type. test->irq_type is by default
> > IRQ_TYPE_UNDEFINED (until someone calls ioctl(PCITEST_SET_IRQTYPE)).
> >
> > However, the commit also changed so that after initializing test->irq_type
> > to IRQ_TYPE_UNDEFINED, it also overrides it with driver_data->irq_type, if
> > the PCI device and vendor ID provides driver_data.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] misc: pci_endpoint_test: Defer IRQ allocation until ioctl(PCITEST_SET_IRQTYPE)
> commit: 9d564bf7ab67ec326ec047d2d95087d8d888f9b1
a402006d48a9c ("misc: pci_endpoint_test: Remove global 'irq_type' and
'no_msi'") appeared in v6.15-rc1, and apparently caused a regression
that some driver fails to probe on such platforms.
Since a402006d48a9c caused a regression and hasn't appeared in a
release yet, this sounds like a candidate for v6.15 via pci/for-linus?
I can move it if you agree. I *would* like to have a little more
detail about the regression, e.g., the affected driver, so I can
justify merging this after the merge window.
Bjorn
next prev parent reply other threads:[~2025-04-22 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 14:28 [PATCH RESEND] misc: pci_endpoint_test: Defer IRQ allocation until ioctl(PCITEST_SET_IRQTYPE) Niklas Cassel
2025-04-20 4:01 ` Manivannan Sadhasivam
2025-04-22 17:53 ` Bjorn Helgaas [this message]
2025-04-23 12:46 ` Niklas Cassel
2025-04-23 22:19 ` Bjorn Helgaas
2025-04-23 22:23 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422175319.GA373387@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.