From: Simon Horman <horms@kernel.org>
To: linux@treblig.org
Cc: dhowells@redhat.com, marc.dionne@auristor.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, corbet@lwn.net, linux-afs@lists.infradead.org,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] rxrpc: Remove deadcode
Date: Tue, 22 Apr 2025 19:22:29 +0100 [thread overview]
Message-ID: <20250422182229.GM2843373@horms.kernel.org> (raw)
In-Reply-To: <20250417153232.32139-1-linux@treblig.org>
On Thu, Apr 17, 2025 at 04:32:32PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> Remove three functions that are no longer used.
>
> rxrpc_get_txbuf() last use was removed by 2020's
> commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and
> local processor work")
>
> rxrpc_kernel_get_epoch() last use was removed by 2020's
> commit 44746355ccb1 ("afs: Don't get epoch from a server because it may be
> ambiguous")
>
> rxrpc_kernel_set_max_life() last use was removed by 2023's
> commit db099c625b13 ("rxrpc: Fix timeout of a call that hasn't yet been
> granted a channel")
>
> Both of the rxrpc_kernel_* functions were documented. Remove that
> documentation as well as the code.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Hi David,
This patch doesn't apply to net-next. Probably because of commit
23738cc80483 ("rxrpc: Pull out certain app callback funcs into an ops
table"). So please rebase and repost.
But other than that, this patch looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
...
--
pw-bot: changes-requested
next prev parent reply other threads:[~2025-04-22 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 15:32 [PATCH net-next] rxrpc: Remove deadcode linux
2025-04-22 18:22 ` Simon Horman [this message]
2025-04-22 20:59 ` Dr. David Alan Gilbert
2025-04-22 23:52 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422182229.GM2843373@horms.kernel.org \
--to=horms@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.