All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: buildroot@buildroot.org, "Yann E. MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v2] package/linux-tools: Fix parallel compilation
Date: Tue, 22 Apr 2025 21:43:09 +0200	[thread overview]
Message-ID: <20250422214309.330035ae@windsurf> (raw)
In-Reply-To: <20250421-fix_linux_tools_parallel-v2-1-301086814e0b@rivosinc.com>

On Mon, 21 Apr 2025 23:36:59 -0700
Charlie Jenkins <charlie@rivosinc.com> wrote:

> linux-tools opportunistically set linux as only a patch dependency. This
> unfortunately introduces a race condition in the shared linux scripts
> when using PER_PACKAGE_DIRECTORIES and using top level parallelism. The
> race manifests as the error "/bin/sh: 1: scripts/basic/fixdep:
> Permission denied". This happens when the linux package and the
> linux-tools package are being compiled in parallel.
> 
> The linux-tools currently using fixdep are perf and rtla. When the
> timing is correct, perf, rtla, or the kernel Makefile will try to use
> fixdep while one of the others is compiling fixed, resulting in fixdep
> being briefly not available.
> 
> To fix this, set linux as a build dependency instead of a patch
> dependency.
> 
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> While the timing of this seems like it should very rarely be triggered,
> on my build server I hit this issue nearly 100% of the time.
> ---
> Changes in v2:
> - Added more details to how/why the race occurs
> - Link to v1: https://lore.kernel.org/r/20250409-fix_linux_tools_parallel-v1-1-14135d77acf1@rivosinc.com
> ---
>  package/linux-tools/linux-tools.mk | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Nice commit message, thanks a lot! Applied.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-04-22 19:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22  6:36 [Buildroot] [PATCH v2] package/linux-tools: Fix parallel compilation Charlie Jenkins
2025-04-22 19:43 ` Thomas Petazzoni via buildroot [this message]
2025-05-02 11:03 ` Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422214309.330035ae@windsurf \
    --to=buildroot@buildroot.org \
    --cc=charlie@rivosinc.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.