From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 553DE1F4CA3; Tue, 22 Apr 2025 06:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745304260; cv=none; b=sBH4nhPBNn77q31uZLnSZVf10LUU5VmscfCoE5rO+9g1xBc9+KLCjrJ4zqdDSlA7uWkyETp8+mWVRwZn5tm3ltRSszeSDQla45RRrPB4W49zRGPeaESSNzceuAN4PDeob3FR/WNTeiWUcUTDXiyjW4E9ydwSUU2NjL06aJVcwLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745304260; c=relaxed/simple; bh=wCOgTUg+pu7hi/GrVi9nZ/hK6QRfk7G3uZwoEjOovf4=; h=Subject:To:Cc:From:Date:In-Reply-To:Message-ID:MIME-Version: Content-Type; b=St4JBdYRFGm0/owyokdow9BlrHoFMNbv/ncx76YwSpcOn6GO+GhYIrpV5aJNbY0/wCPt4AWcJzbpCXwnt8Mll0TbFbz4RocqGhTZ1CbP/VEJDddzcZ0YIFVDPMpFVL/DkDo8hn3XU1TkDJTgLM5K9Acul+bIHTb7v8a09+BXS0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=e5mmuC5S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="e5mmuC5S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9A21C4CEEA; Tue, 22 Apr 2025 06:44:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745304260; bh=wCOgTUg+pu7hi/GrVi9nZ/hK6QRfk7G3uZwoEjOovf4=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=e5mmuC5SzLA78IRc19Cr6UtM+st3eGEUAW0xXCMsiaSr0CjusoSGjT44ApS4y2NGb gCscGVVXwuhKNdMhlG4BrwHjwLl3MXdsSMHy2tT4702x5L6Tv8mvzkfTbuCDyU2+MN dOqbxS8n8br5HgI65D6Cs52okdbIWNbR108PGfx8= Subject: Patch "KVM: arm64: Remove host FPSIMD saving for non-protected KVM" has been added to the 6.1-stable tree To: broonie@kernel.org,catalin.marinas@arm.com,gregkh@linuxfoundation.org,james.morse@arm.com,kvmarm@lists.cs.columbia.edu,kvmarm@lists.linux.dev,linux-arm-kernel@lists.infradead.org,mark.rutland@arm.com,maz@kernel.org,oleg@redhat.com,oliver.upton@linux.dev,suzuki.poulose@arm.com,tabba@google.com,will@kernel.org Cc: From: Date: Tue, 22 Apr 2025 08:43:54 +0200 In-Reply-To: <20250404-stable-sve-6-1-v1-6-cd5c9eb52d49@kernel.org> Message-ID: <2025042254-dividend-despair-bd5b@gregkh> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled KVM: arm64: Remove host FPSIMD saving for non-protected KVM to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: kvm-arm64-remove-host-fpsimd-saving-for-non-protected-kvm.patch and it can be found in the queue-6.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From broonie@kernel.org Fri Apr 4 15:27:48 2025 From: Mark Brown Date: Fri, 04 Apr 2025 14:23:39 +0100 Subject: KVM: arm64: Remove host FPSIMD saving for non-protected KVM To: Catalin Marinas , Will Deacon , Marc Zyngier , James Morse , Suzuki K Poulose , Oliver Upton , Oleg Nesterov , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, Mark Brown , stable@vger.kernel.org, Mark Rutland , Fuad Tabba Message-ID: <20250404-stable-sve-6-1-v1-6-cd5c9eb52d49@kernel.org> From: Mark Rutland [ Upstream commit 8eca7f6d5100b6997df4f532090bc3f7e0203bef ] Now that the host eagerly saves its own FPSIMD/SVE/SME state, non-protected KVM never needs to save the host FPSIMD/SVE/SME state, and the code to do this is never used. Protected KVM still needs to save/restore the host FPSIMD/SVE state to avoid leaking guest state to the host (and to avoid revealing to the host whether the guest used FPSIMD/SVE/SME), and that code needs to be retained. Remove the unused code and data structures. To avoid the need for a stub copy of kvm_hyp_save_fpsimd_host() in the VHE hyp code, the nVHE/hVHE version is moved into the shared switch header, where it is only invoked when KVM is in protected mode. Signed-off-by: Mark Rutland Reviewed-by: Mark Brown Tested-by: Mark Brown Acked-by: Will Deacon Cc: Catalin Marinas Cc: Fuad Tabba Cc: Marc Zyngier Cc: Oliver Upton Reviewed-by: Oliver Upton Link: https://lore.kernel.org/r/20250210195226.1215254-3-mark.rutland@arm.com Signed-off-by: Marc Zyngier Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- arch/arm64/include/asm/kvm_host.h | 1 - arch/arm64/kvm/fpsimd.c | 2 -- arch/arm64/kvm/hyp/include/hyp/switch.h | 4 ---- 3 files changed, 7 deletions(-) --- a/arch/arm64/include/asm/kvm_host.h +++ b/arch/arm64/include/asm/kvm_host.h @@ -380,7 +380,6 @@ struct kvm_vcpu_arch { struct kvm_guest_debug_arch vcpu_debug_state; struct kvm_guest_debug_arch external_debug_state; - struct user_fpsimd_state *host_fpsimd_state; /* hyp VA */ struct task_struct *parent_task; struct { --- a/arch/arm64/kvm/fpsimd.c +++ b/arch/arm64/kvm/fpsimd.c @@ -49,8 +49,6 @@ int kvm_arch_vcpu_run_map_fp(struct kvm_ if (ret) return ret; - vcpu->arch.host_fpsimd_state = kern_hyp_va(fpsimd); - /* * We need to keep current's task_struct pinned until its data has been * unshared with the hypervisor to make sure it is not re-used by the --- a/arch/arm64/kvm/hyp/include/hyp/switch.h +++ b/arch/arm64/kvm/hyp/include/hyp/switch.h @@ -207,10 +207,6 @@ static bool kvm_hyp_handle_fpsimd(struct } isb(); - /* Write out the host state if it's in the registers */ - if (vcpu->arch.fp_state == FP_STATE_HOST_OWNED) - __fpsimd_save_state(vcpu->arch.host_fpsimd_state); - /* Restore the guest state */ if (sve_guest) __hyp_sve_restore_guest(vcpu); Patches currently in stable-queue which might be from broonie@kernel.org are queue-6.1/kvm-arm64-remove-host-fpsimd-saving-for-non-protected-kvm.patch queue-6.1/spi-cadence-qspi-fix-probe-on-am62a-lp-sk.patch queue-6.1/asoc-qdsp6-q6asm-dai-fix-q6asm_dai_compr_set_params-error-path.patch queue-6.1/asoc-qdsp6-q6apm-dai-fix-capture-pipeline-overruns.patch queue-6.1/kvm-arm64-mark-some-header-functions-as-inline.patch queue-6.1/kvm-arm64-eagerly-switch-zcr_el-1-2.patch queue-6.1/kvm-arm64-unconditionally-save-flush-host-fpsimd-sve-sme-state.patch queue-6.1/asoc-amd-add-dmi-quirk-for-acp6x-mic-support.patch queue-6.1/kvm-arm64-refactor-exit-handlers.patch queue-6.1/asoc-qdsp6-q6apm-dai-set-10-ms-period-and-buffer-alignment.patch queue-6.1/asoc-codecs-lpass-wsa-macro-fix-vi-feedback-rate.patch queue-6.1/arm64-fpsimd-track-the-saved-fpsimd-state-type-separately-to-tif_sve.patch queue-6.1/kvm-arm64-remove-vhe-host-restore-of-cpacr_el1.zen.patch queue-6.1/kvm-arm64-remove-vhe-host-restore-of-cpacr_el1.smen.patch queue-6.1/asoc-fsl_audmix-register-card-device-depends-on-dais.patch queue-6.1/arm64-fpsimd-have-kvm-explicitly-say-which-fp-registers-to-save.patch queue-6.1/kvm-arm64-discard-any-sve-state-when-entering-kvm-guests.patch queue-6.1/arm64-fpsimd-stop-using-tif_sve-to-manage-register-saving-in-kvm.patch queue-6.1/asoc-codecs-lpass-wsa-macro-fix-logic-of-enabling-vi-channels.patch queue-6.1/kvm-arm64-calculate-cptr_el2-traps-on-activating-traps.patch