From: Sumit Garg <sumit.garg@kernel.org>
To: u-boot-qcom@groups.io, u-boot@lists.denx.de
Cc: trini@konsulko.com, casey.connolly@linaro.org,
neil.armstrong@linaro.org, loic.minier@oss.qualcomm.com,
Sumit Garg <sumit.garg@oss.qualcomm.com>
Subject: [PATCH] mach-snapdragon: Update fdtfile logic to work for RB1 and RB2
Date: Wed, 23 Apr 2025 10:41:32 +0530 [thread overview]
Message-ID: <20250423051132.292329-1-sumit.garg@kernel.org> (raw)
From: Sumit Garg <sumit.garg@oss.qualcomm.com>
RB1 and RB2 have three root compatibles where the last one can't be used
to decode fdtfile name (qcm* vs qrb*). So rather just rely on the first
compatible to retrieve the SoC name.
Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
arch/arm/mach-snapdragon/board.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-snapdragon/board.c b/arch/arm/mach-snapdragon/board.c
index deae4d32378..dc8220e89b4 100644
--- a/arch/arm/mach-snapdragon/board.c
+++ b/arch/arm/mach-snapdragon/board.c
@@ -437,16 +437,24 @@ static void configure_env(void)
/* The Qualcomm reference boards (RBx, HDK, etc) */
if (!strncmp("qcom", buf, strlen("qcom"))) {
+ char *soc;
+
/*
* They all have the first compatible as "qcom,<soc>-<board>"
* (e.g. "qcom,qrb5165-rb5"). We extract just the part after
* the dash.
*/
- if (!strsep(&tmp, "-")) {
+ if (!strsep(&tmp, ",")) {
+ log_warning("compatible '%s' has no ','\n", buf);
+ return;
+ }
+ soc = strsep(&tmp, "-");
+ if (!soc) {
log_warning("compatible '%s' has no '-'\n", buf);
return;
}
- /* tmp is now "rb5" */
+
+ env_set("soc", soc);
env_set("board", tmp);
} else {
if (!strsep(&tmp, ",")) {
--
2.43.0
next reply other threads:[~2025-04-23 5:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 5:11 Sumit Garg [this message]
2025-05-05 5:23 ` [PATCH] mach-snapdragon: Update fdtfile logic to work for RB1 and RB2 Sumit Garg
2025-05-05 7:23 ` neil.armstrong
[not found] ` <183C90A92BBF63A5.32718@groups.io>
2025-05-05 7:26 ` neil.armstrong
2025-05-05 9:31 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423051132.292329-1-sumit.garg@kernel.org \
--to=sumit.garg@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=loic.minier@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=sumit.garg@oss.qualcomm.com \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.