From: Jamin Lin via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>
Cc: <jamin_lin@aspeedtech.com>, <troy_lee@aspeedtech.com>,
<nabihestefan@google.com>
Subject: [PATCH v5 02/11] hw/arm/aspeed_ast27x0 Introduce vbootrom memory region
Date: Wed, 23 Apr 2025 15:23:38 +0800 [thread overview]
Message-ID: <20250423072350.541742-3-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20250423072350.541742-1-jamin_lin@aspeedtech.com>
Introduce a new vbootrom memory region. The region is mapped at address
"0x00000000" and has a size of 128KB, identical to the SRAM region size.
This memory region is intended for loading a vbootrom image file as part of the
boot process.
The vbootrom registered in the SoC's address space using the ASPEED_DEV_VBOOTROM
index.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Nabih Estefan <nabihestefan@google.com>
Tested-by: Nabih Estefan <nabihestefan@google.com>
---
include/hw/arm/aspeed_soc.h | 2 ++
hw/arm/aspeed_ast27x0.c | 9 +++++++++
2 files changed, 11 insertions(+)
diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h
index f069d17d16..b4b23d693d 100644
--- a/include/hw/arm/aspeed_soc.h
+++ b/include/hw/arm/aspeed_soc.h
@@ -59,6 +59,7 @@ struct AspeedSoCState {
MemoryRegion sram;
MemoryRegion spi_boot_container;
MemoryRegion spi_boot;
+ MemoryRegion vbootrom;
AddressSpace dram_as;
AspeedRtcState rtc;
AspeedTimerCtrlState timerctrl;
@@ -169,6 +170,7 @@ struct AspeedSoCClass {
const char *aspeed_soc_cpu_type(AspeedSoCClass *sc);
enum {
+ ASPEED_DEV_VBOOTROM,
ASPEED_DEV_SPI_BOOT,
ASPEED_DEV_IOMEM,
ASPEED_DEV_UART0,
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index b05ed75ff4..968dfa5526 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -24,6 +24,7 @@
#include "qemu/log.h"
static const hwaddr aspeed_soc_ast2700_memmap[] = {
+ [ASPEED_DEV_VBOOTROM] = 0x00000000,
[ASPEED_DEV_SRAM] = 0x10000000,
[ASPEED_DEV_HACE] = 0x12070000,
[ASPEED_DEV_EMMC] = 0x12090000,
@@ -657,6 +658,14 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)
memory_region_add_subregion(s->memory,
sc->memmap[ASPEED_DEV_SRAM], &s->sram);
+ /* VBOOTROM */
+ if (!memory_region_init_ram(&s->vbootrom, OBJECT(s), "aspeed.vbootrom",
+ 0x20000, errp)) {
+ return;
+ }
+ memory_region_add_subregion(s->memory,
+ sc->memmap[ASPEED_DEV_VBOOTROM], &s->vbootrom);
+
/* SCU */
if (!sysbus_realize(SYS_BUS_DEVICE(&s->scu), errp)) {
return;
--
2.43.0
next prev parent reply other threads:[~2025-04-23 7:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 7:23 [PATCH v5 00/11] Support vbootrom for AST2700 Jamin Lin via
2025-04-23 7:23 ` [PATCH v5 01/11] hw/arm/aspeed_ast27x0: Rename variable sram_name to name in ast2700 realize Jamin Lin via
2025-04-23 7:23 ` Jamin Lin via
2025-04-23 7:23 ` Jamin Lin via [this message]
2025-04-23 7:39 ` [PATCH v5 02/11] hw/arm/aspeed_ast27x0 Introduce vbootrom memory region Cédric Le Goater
2025-04-23 7:23 ` [PATCH v5 03/11] hw/arm/aspeed: Add vbootrom support on AST2700 EVB machines Jamin Lin via
2025-04-23 7:23 ` Jamin Lin via
2025-04-23 9:29 ` Cédric Le Goater
2025-04-24 4:00 ` Jamin Lin
2025-04-23 7:23 ` [PATCH v5 04/11] hw/arm/aspeed: Reuse rom_size variable for vbootrom setup Jamin Lin via
2025-04-23 7:23 ` Jamin Lin via
2025-04-23 9:20 ` Cédric Le Goater
2025-04-24 3:59 ` Jamin Lin
2025-04-23 7:23 ` [PATCH v5 05/11] pc-bios: Add AST27x0 vBootrom Jamin Lin via
2025-04-23 9:28 ` Cédric Le Goater
2025-04-23 20:29 ` Nabih Estefan
2025-04-23 21:28 ` Cédric Le Goater
2025-04-23 7:23 ` [PATCH v5 06/11] hw/arm/aspeed: Add support for loading vbootrom image via "-bios" Jamin Lin via
2025-04-23 9:23 ` Cédric Le Goater
2025-04-24 4:01 ` Jamin Lin
2025-04-23 7:23 ` [PATCH v5 07/11] tests/functional/aspeed: Move I2C test into shared helper for AST2700 reuse Jamin Lin via
2025-04-23 7:23 ` Jamin Lin via
2025-04-23 7:23 ` [PATCH v5 08/11] tests/functional/aspeed: Update test ASPEED SDK v09.06 Jamin Lin via
2025-04-23 7:23 ` [PATCH v5 09/11] tests/functional/aspeed: extract boot and login sequence into helper function Jamin Lin via
2025-04-23 7:23 ` Jamin Lin via
2025-04-23 7:40 ` Cédric Le Goater
2025-04-23 7:23 ` [PATCH v5 10/11] tests/functional/aspeed: Add to test vbootrom for AST2700 Jamin Lin via
2025-04-23 21:27 ` Cédric Le Goater
2025-04-23 7:23 ` [PATCH v5 11/11] docs/system/arm/aspeed: Support " Jamin Lin via
2025-04-23 9:49 ` Cédric Le Goater
2025-04-23 9:36 ` [PATCH v5 00/11] " Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423072350.541742-3-jamin_lin@aspeedtech.com \
--to=qemu-devel@nongnu.org \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=nabihestefan@google.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.