From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <djwong@kernel.org>,
brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz,
cem@kernel.org, linux-fsdevel@vger.kernel.org,
dchinner@redhat.com, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com,
ritesh.list@gmail.com, martin.petersen@oracle.com,
linux-ext4@vger.kernel.org, linux-block@vger.kernel.org,
catherine.hoang@oracle.com, linux-api@vger.kernel.org
Subject: Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
Date: Wed, 23 Apr 2025 10:33:17 +0200 [thread overview]
Message-ID: <20250423083317.GB30432@lst.de> (raw)
In-Reply-To: <f27ea8f7-700a-4fb1-b9cd-a0cba04c9e47@oracle.com>
On Wed, Apr 23, 2025 at 09:28:14AM +0100, John Garry wrote:
>> But maybe we should just delay setting the atomic values until later so
>> that it can be done in a single pass? E.g. into xfs_setsize_buftarg
>> which then should probably be rename to something like
>> xfs_buftarg_setup.
>>
>
> How about just do away with btp->bt_bdev_awu_{min, max} struct members, and
> call bdev_atomic_write_unit_max(mp->m_ddev_targp->bt_bdev) [and same for
> RT] to later to set the mp awu max values at mountfs time? I think that
> would work..
Sounds reasonable.
next prev parent reply other threads:[~2025-04-23 8:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 12:27 [PATCH v8 00/15] large atomic writes for xfs John Garry
2025-04-22 12:27 ` [PATCH v8 01/15] fs: add atomic write unit max opt to statx John Garry
2025-04-22 12:27 ` [PATCH v8 02/15] xfs: add helpers to compute log item overhead John Garry
2025-04-22 12:27 ` [PATCH v8 03/15] xfs: add helpers to compute transaction reservation for finishing intent items John Garry
2025-04-22 12:27 ` [PATCH v8 04/15] xfs: rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomicwrite() John Garry
2025-04-22 12:27 ` [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block John Garry
2025-04-23 0:38 ` Darrick J. Wong
2025-04-23 7:15 ` John Garry
2025-04-23 8:10 ` Christoph Hellwig
2025-04-23 8:28 ` John Garry
2025-04-23 8:33 ` Christoph Hellwig [this message]
2025-04-23 15:12 ` Darrick J. Wong
2025-04-23 15:46 ` Christoph Hellwig
2025-04-22 12:27 ` [PATCH v8 06/15] xfs: allow block allocator to take an alignment hint John Garry
2025-04-22 12:27 ` [PATCH v8 07/15] xfs: refactor xfs_reflink_end_cow_extent() John Garry
2025-04-22 12:27 ` [PATCH v8 08/15] xfs: refine atomic write size check in xfs_file_write_iter() John Garry
2025-04-22 12:27 ` [PATCH v8 09/15] xfs: add xfs_atomic_write_cow_iomap_begin() John Garry
2025-04-23 8:12 ` Christoph Hellwig
2025-04-22 12:27 ` [PATCH v8 10/15] xfs: add large atomic writes checks in xfs_direct_write_iomap_begin() John Garry
2025-04-23 8:16 ` Christoph Hellwig
2025-04-23 8:18 ` John Garry
2025-04-22 12:27 ` [PATCH v8 11/15] xfs: commit CoW-based atomic writes atomically John Garry
2025-04-23 8:23 ` Christoph Hellwig
2025-04-23 14:58 ` Darrick J. Wong
2025-04-23 15:53 ` Christoph Hellwig
2025-04-23 15:58 ` Darrick J. Wong
2025-04-23 16:38 ` John Garry
2025-04-22 12:27 ` [PATCH v8 12/15] xfs: add xfs_file_dio_write_atomic() John Garry
2025-04-23 8:25 ` Christoph Hellwig
2025-04-23 8:29 ` John Garry
2025-04-22 12:27 ` [PATCH v8 13/15] xfs: add xfs_compute_atomic_write_unit_max() John Garry
2025-04-23 8:26 ` Christoph Hellwig
2025-04-22 12:27 ` [PATCH v8 14/15] xfs: update atomic write limits John Garry
2025-04-23 8:27 ` Christoph Hellwig
2025-04-22 12:27 ` [PATCH v8 15/15] xfs: allow sysadmins to specify a maximum atomic write limit at mount time John Garry
2025-04-23 8:32 ` Christoph Hellwig
2025-04-23 15:01 ` Darrick J. Wong
2025-04-23 15:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423083317.GB30432@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.