Re: [PATCH v3 4/5] hw/acpi/aml-build: Update the revision of PPTT table

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Apr 23, 2025 at 12:41:29PM +0100, Alireza Sanaee wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
> 
> The lastest ACPI spec 6.5 support PPTT revision 3. Update it
> by handy. This is compatible with previous revision.
> 
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>


I don't get it. Why are you updating it? Which features
from the new one are you using?

> ---
>  hw/acpi/aml-build.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 3010325ca423..e5401dfdb1a8 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -2155,7 +2155,7 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
>      uint32_t pptt_start = table_data->len;
>      uint32_t root_offset;
>      int n;
> -    AcpiTable table = { .sig = "PPTT", .rev = 2,
> +    AcpiTable table = { .sig = "PPTT", .rev = 3,
>                          .oem_id = oem_id, .oem_table_id = oem_table_id };
>  
>      acpi_table_begin(&table, table_data);
> -- 
> 2.34.1