From: "Alexey V. Vissarionov" <gremlin@altlinux.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: "Alexey V. Vissarionov" <gremlin@altlinux.org>,
Rui Miguel Silva <rui.silva@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] usb: isp1760: increase buffer size to avoid overflow
Date: Wed, 23 Apr 2025 14:05:40 +0300 [thread overview]
Message-ID: <20250423110540.GB857@altlinux.org> (raw)
In-Reply-To: <rdsyrsjl67rjhkuatkaggnrfcruvzcxlwnfb6jgqgh5ninlnmj@hy2ofl7jlhei>
Good ${greeting_time}!
On 2025-04-23 09:30:48 +0300, Fedor Pchelkin wrote:
> On Wed, 23. Apr 02:00, Alexey V. Vissarionov wrote:
>> isp1760_field_set() may access the udc->fields array beyond
>> the size of DC_FIELD_MAX up to HC_FIELD_MAX, which is (now)
>> bigger.
> Where exactly does the problem manifest? There is no
> comprehensible bug description here from you..
> Though I guess isp1760_set_pullup() call site is concerned?
Yes, when called from isp1760_udc_init_hw()
+ When isp1760_udc_init_hw() calls isp1760_set_pullup(),
> Please make sure to run your changes through checkpatch.pl and
> the compiler first.
Mea culpa... Sent earlier version.
There should be only one warning on "Comparisons should place
the constant on the right side of the test" when comparing two
constants.
Updated patch follows.
--
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net
next prev parent reply other threads:[~2025-04-23 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 23:00 [PATCH] usb: isp1760: increase buffer size to avoid overflow Alexey V. Vissarionov
2025-04-23 6:30 ` Fedor Pchelkin
2025-04-23 11:05 ` Alexey V. Vissarionov [this message]
2025-04-23 11:10 ` [PATCH v1] " Alexey V. Vissarionov
2025-04-24 9:15 ` Rui Miguel Silva
2025-04-24 10:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423110540.GB857@altlinux.org \
--to=gremlin@altlinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=pchelkin@ispras.ru \
--cc=rui.silva@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.