From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrey Albershteyn <aalbersh@redhat.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] xfs_io: make statx mask parsing more generally useful
Date: Wed, 23 Apr 2025 08:33:52 -0700 [thread overview]
Message-ID: <20250423153352.GF25675@frogsfrogsfrogs> (raw)
In-Reply-To: <aAc1UtYb2HL3w5T_@infradead.org>
On Mon, Apr 21, 2025 at 11:21:06PM -0700, Christoph Hellwig wrote:
> On Tue, Apr 15, 2025 at 10:22:51PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Enhance the statx -m parsing to be more useful:
>
> Btw, -m claims to set STATX_ALL, which the kernel deprecated soon after
> adding it:
>
> * This is deprecated, and shall remain the same value in the future. To avoid
> * confusion please use the equivalent (STATX_BASIC_STATS | STATX_BTIME)
> * instead.
>
> do we need to do something about the -m definition in xfs_io because
> all fields aren't included in STATX_ALL?
Hrm. Nothing in fstests uses it AFAICT so maybe we could just get rid
of the -m option. Or we could redefine "all" to map to ~1U so it
actually does what that word means?
--D
next prev parent reply other threads:[~2025-04-23 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 5:21 [PATCH 1/2] xfs_io: catch statx fields up to 6.15 Darrick J. Wong
2025-04-16 5:22 ` [PATCH 2/2] xfs_io: make statx mask parsing more generally useful Darrick J. Wong
2025-04-16 9:50 ` Andrey Albershteyn
2025-04-22 6:21 ` Christoph Hellwig
2025-04-23 15:33 ` Darrick J. Wong [this message]
2025-04-23 15:44 ` Christoph Hellwig
2025-04-16 9:15 ` [PATCH 1/2] xfs_io: catch statx fields up to 6.15 Andrey Albershteyn
2025-04-22 6:15 ` Christoph Hellwig
2025-04-23 15:31 ` Darrick J. Wong
2025-04-23 15:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423153352.GF25675@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.