From: Gyeyoung Baek <gye976@gmail.com>
To: andy@kernel.org
Cc: Gyeyoung Baek <gye976@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, jic23@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 3/4] iio: chemical: add support for winsen MHZ19B CO2 sensor
Date: Thu, 24 Apr 2025 00:59:48 +0900 [thread overview]
Message-ID: <20250423155948.20576-1-gye976@gmail.com> (raw)
In-Reply-To: <aAfUZuujO0FUkJEG@smile.fi.intel.com>
> > + if (ppm) {
> > + if (!in_range(ppm, 1000, 4001)) {
> > + dev_dbg(&indio_dev->dev,
> > + "span point ppm should be between 1000 and 5000 inclusive.");
> > + return -EINVAL;
> > + }
>
> I proposed to define the _MIN and _MAX constants for the range and use them in
> the parameters. Any objection?
I'm sorry, my Gmail didn’t show your replies for some reason, so I missed your previous review.
I only noticed it after checking iio lore directly.
It seems more readable to use _MIN and _MAX. I'll use those, thanks!
---
> > +
> > + return len;
> > +}
>
> Otherwise LGTM, thanks!
I'll send new patch based on your other review comments.
thanks.
--
Regards,
Gyeyoung
next prev parent reply other threads:[~2025-04-23 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 15:52 [PATCH v5 0/4] add support for winsen MHZ19B CO2 sensor Gyeyoung Baek
2025-04-22 15:52 ` [PATCH v5 1/4] dt-bindings: add winsen to the vendor prefixes Gyeyoung Baek
2025-04-22 15:53 ` [PATCH v5 2/4] dt-bindings: add device tree support for winsen MHZ19B CO2 sensor Gyeyoung Baek
2025-04-22 15:53 ` [PATCH v5 3/4] iio: chemical: add " Gyeyoung Baek
2025-04-22 17:39 ` Andy Shevchenko
2025-04-23 15:59 ` Gyeyoung Baek [this message]
2025-04-22 15:53 ` [PATCH v5 4/4] MAINTAINERS: Add WINSEN MHZ19B Gyeyoung Baek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423155948.20576-1-gye976@gmail.com \
--to=gye976@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.