From: Greg KH <gregkh@linuxfoundation.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Maximilian Weigand <mweigand@mweigand.net>,
Alistair Francis <alistair@alistair23.me>,
Mikael Gonella-Bolduc <mgonellabolduc@dimonoff.com>,
stable@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: cyttsp5 - fix power control issue on wakeup
Date: Wed, 23 Apr 2025 08:12:42 +0200 [thread overview]
Message-ID: <2025042327-stunning-backside-2849@gregkh> (raw)
In-Reply-To: <20250422145026.517153d645441bc5f51eae93@hugovil.com>
On Tue, Apr 22, 2025 at 02:50:26PM -0400, Hugo Villeneuve wrote:
> On Tue, 22 Apr 2025 14:43:24 -0400
> Hugo Villeneuve <hugo@hugovil.com> wrote:
>
> > From: Mikael Gonella-Bolduc <mgonellabolduc@dimonoff.com>
> >
> > The power control function ignores the "on" argument when setting the
> > report ID, and thus is always sending HID_POWER_SLEEP. This causes a
> > problem when trying to wakeup.
> >
> > Fix by sending the state variable, which contains the proper HID_POWER_ON or
> > HID_POWER_SLEEP based on the "on" argument.
> >
> > Fixes: 3c98b8dbdced ("Input: cyttsp5 - implement proper sleep and wakeup procedures")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> I inadvertently removed Mikael SOB tag, I can re-add it if a V2 is
> needed.
You can't remove it, please add it back.
prev parent reply other threads:[~2025-04-23 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 18:43 [PATCH] Input: cyttsp5 - fix power control issue on wakeup Hugo Villeneuve
2025-04-22 18:50 ` Hugo Villeneuve
2025-04-23 6:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042327-stunning-backside-2849@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alistair@alistair23.me \
--cc=dmitry.torokhov@gmail.com \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgonellabolduc@dimonoff.com \
--cc=mweigand@mweigand.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.