From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74806C369AB for ; Thu, 24 Apr 2025 17:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S+ZOONTbV3e6RrR2mK3HpPOGRLmBXneKTDHuUdGgYaw=; b=I/BDrs8yETDKuX EgizZkxxcxiJf3oveoJZ3Pfm/qPSKHwQVl4Qs+tsQc7JDe9E5l9TzzRoWpM3DgDTfAKR4swneloj7 ymhOps213GsrCwahA+/hscCkxKTiGXhfx9iENS53g6BVVnNGPIRhE+qgZrrZzkAcLJjJdAGi9j+O2 bJbnMGVPaLcypbjeRbMkVgcq1nC1T0jiquDGURN7bnCcZV3HrGY05557/C7QmZZmh4C08URrBm4ur 5WU9g86tJizG5jVI4MKe7i6514kkOMxmg39TE6JF5dnpVUYzMGF/fnLLH+kXcotxI6gzxHm4usWWe fBrukZlyp5mrlYXqbHkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u807c-0000000Er5t-10BS; Thu, 24 Apr 2025 17:12:24 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7xF7-0000000EJrm-1QmY for kvm-riscv@lists.infradead.org; Thu, 24 Apr 2025 14:07:58 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-43ce70f9afbso9388415e9.0 for ; Thu, 24 Apr 2025 07:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1745503676; x=1746108476; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=U0v6f9lKAMd35DpCsKVbL9D2wBml6curMV8py2v4cGU=; b=hdRuWbdw4c2DcMYLf+PXOIdqVKmLFo8VPftbpTbrtywiwH9pYNFL8QHUJ8I/dYjR+X 9BOAK981ldNNPnSLViWtLdPajj3rWq76L7MFw6AkuY7jQUw/RXXWDqDu6dpY0//7Nvgc 1SzNYcUjBe8wCTyi88m3tGMisNc5QPoS8mrCrrUXFeHS+CUvZrkix/9gWOuBoVCqJCWw 96ElFYWbFhFqsUQccbm9YaKMvIoD4dmOjTr98n3gcA5A++Y1PaYDfl6x0fK6kQoJ6j9X ivCAdz+nr5lmkMW9WZ5LKJ6c4Rndpuj3+N4mN57eg0tuTLHMK7waKOmimYTdj9IQzAGa SaMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745503676; x=1746108476; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U0v6f9lKAMd35DpCsKVbL9D2wBml6curMV8py2v4cGU=; b=dQY8l8QGkYxFWkbraVNxkyxh1sssuGZI006+Jdz5yuT2iXi5NgJp+qeWTD/z1iBUZk epuHl6aH+NBdFsCtJYC5gAUIsEZlhKHsPyCPrnMnZ4luUx8K0ea4h5Ofaeb+DZd3CbVJ eAnqmyNOGn19kS7xzZVGmT+z54f/oyt6jceWkROL+IH7XMd3pgzLQVQx8QJLuF7ONqQI wfuILuf6/roJTBpg3KZbUe0huco9WZ0Bq68hjuqGXfvoN3mQnrXIxaca7kXQy2cWwlzj HvvG4zX1mbclaB9gLE36IdNtnG+Db73Xdvw9aJscVR9ySu7pGZNTnXlwtOeBUes7HIQQ 1UQA== X-Forwarded-Encrypted: i=1; AJvYcCVHx58FkGVlw+PX9jsshDQ3a63V06fEcCDi+GA4GvsgiKfNRzczDoFLIl5CjKCdZJdcxoflxzTYLVU=@lists.infradead.org X-Gm-Message-State: AOJu0Yw8jDG0DtXtdy54waKdFf1H+s/ExH7O9MAHMy/HBbwJQA6/FgmF uB/WuTd3nHeREmlO9Ybyir92DY1GXGu0uPLCvintQWSpwKJVNsUnY/tkWN+V0ZU= X-Gm-Gg: ASbGnctAzVeJw7zCateCGUicfk+EH/2PWAnnAgmj8tJ3r4ndBubvuCCm38RaMiYNqLB rkmZvHj9X+gUL7xLFxiYJpKthf5ZER8Dw1hUHWAeZQEFYa8EsmV2RvV9YBIzq1quDQdMKm066nX TV3n6AfKQwT1T70TILzSkHOhz4AQNwVPln1ZDohqBEZZ2tFxfSYeWb9Kb55VP7FmEVQi7PSBzr+ 9NKv7/6MeHZJZvZss593oSf7CkiEYQQdtdZwY1JuHbmiH81lcUG3DTGRWc/epSTH9AKKVuGavqg z10ImWEY5q9wd1JGPxGY5iaBNzUYb6TnBICeS/c= X-Google-Smtp-Source: AGHT+IFUPMtP/KjaYEN9MtbB/NYTf0ZhorBZP9X4u5pu7YG//9ef9TT7MFoljX3EChphPUpWA7o/8A== X-Received: by 2002:a05:600c:a00d:b0:43d:7588:6688 with SMTP id 5b1f17b1804b1-4409bd18492mr27593225e9.12.1745503675515; Thu, 24 Apr 2025 07:07:55 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::f716]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2ac27dsm22476585e9.22.2025.04.24.07.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 07:07:55 -0700 (PDT) Date: Thu, 24 Apr 2025 16:07:54 +0200 From: Andrew Jones To: Anup Patel Cc: Will Deacon , julien.thierry.kdev@gmail.com, maz@kernel.org, Paolo Bonzini , Atish Patra , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org Subject: Re: [kvmtool PATCH 10/10] riscv: Allow including extensions in the min CPU type using command-line Message-ID: <20250424-153e6b09d5f0ccdee057a0d9@orel> References: <20250326065644.73765-1-apatel@ventanamicro.com> <20250326065644.73765-11-apatel@ventanamicro.com> <20250412-bc81866c2227ed98429f86b5@orel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250424_070757_379451_0620A5B8 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMjQsIDIwMjUgYXQgMDc6MDI6MThQTSArMDUzMCwgQW51cCBQYXRlbCB3cm90 ZToKPiBPbiBTYXQsIEFwciAxMiwgMjAyNSBhdCA3OjE14oCvUE0gQW5kcmV3IEpvbmVzIDxham9u ZXNAdmVudGFuYW1pY3JvLmNvbT4gd3JvdGU6Cj4gPiA+ICBib29sIHJpc2N2X19pc2FfZXh0ZW5z aW9uX2Rpc2FibGVkKHN0cnVjdCBrdm0gKmt2bSwgdW5zaWduZWQgbG9uZyBpc2FfZXh0X2lkKQo+ ID4gPiAgewo+ID4gPiAgICAgICBzdHJ1Y3QgaXNhX2V4dF9pbmZvICppbmZvID0gTlVMTDsKPiA+ ID4gQEAgLTEyOCwxNiArMTQyLDM5IEBAIGJvb2wgcmlzY3ZfX2lzYV9leHRlbnNpb25fZGlzYWJs ZWQoc3RydWN0IGt2bSAqa3ZtLCB1bnNpZ25lZCBsb25nIGlzYV9leHRfaWQpCj4gPiA+ICBpbnQg cmlzY3ZfX2NwdV90eXBlX3BhcnNlcihjb25zdCBzdHJ1Y3Qgb3B0aW9uICpvcHQsIGNvbnN0IGNo YXIgKmFyZywgaW50IHVuc2V0KQo+ID4gPiAgewo+ID4gPiAgICAgICBzdHJ1Y3Qga3ZtICprdm0g PSBvcHQtPnB0cjsKPiA+ID4gKyAgICAgY29uc3QgY2hhciAqc3RyLCAqbnN0cjsKPiA+ID4gKyAg ICAgaW50IGxlbjsKPiA+ID4KPiA+ID4gLSAgICAgaWYgKChzdHJuY21wKGFyZywgIm1pbiIsIDMp ICYmIHN0cm5jbXAoYXJnLCAibWF4IiwgMykpIHx8IHN0cmxlbihhcmcpICE9IDMpCj4gPiA+ICsg ICAgIGlmICgoc3RybmNtcChhcmcsICJtaW4iLCAzKSB8fCBzdHJsZW4oYXJnKSA8IDMpICYmCj4g Pgo+ID4gSWYgYXJnID09ICdtaW4nLCB0aGVuIGl0IGNhbid0IGJlIGxlc3MgdGhhbiAzIHNvIHRo ZSAnfHwgc3RybGVuKGFyZykgPCAzJwo+ID4gaXMgZGVhZCBjb2RlLgo+ID4KPiA+ID4gKyAgICAg ICAgIChzdHJuY21wKGFyZywgIm1heCIsIDMpIHx8IHN0cmxlbihhcmcpICE9IDMpKQo+ID4KPiA+ IEkgdGhpbmsgd2Ugd2FudAo+ID4KPiA+ICBpZiAoc3RybGVuKGFyZykgPCAzIHx8Cj4gPiAgICAg IChzdHJsZW4oYXJnKSA9PSAzICYmIHN0cmNtcChhcmcsICJtaW4iKSAmJiBzdHJjbXAoYXJnLCAi bWF4IikpIHx8Cj4gPiAgICAgIHN0cm5jbXAoYXJnLCAibWluIiwgMykpCj4gCj4gTm9wZSwgZm9y IGNwdS10eXBlID0gIm1pbiIgdGhlIHN0cmxlbihhcmcpIGNhbiBiZSBncmVhdGVyIHRoYW4gMwo+ IGJlY2F1c2Ugb2YgY29tbWEgc2VwYXJhdGVkIGV4dGVuc2lvbnMgcHJvdmlkZWQgYXMgcGFydCBv Zgo+IGNwdS10eXBlIHZhbHVlLgoKVGhhdCdzIHdoYXQgdGhlIGxhc3QgY29uZGl0aW9uICdzdHJu Y21wKGFyZywgIm1pbiIsIDMpJyBvZiBteSBwcm9wb3NlZApjb21wb3VuZC1jb25kaXRpb24gaXMg Y29uZmlybWluZy4gVGhhdCBjb25kaXRpb24gaXMgb25seSBjaGVja2VkIGZvcgpzdHJsZW4oYXJn KSA+IDMuCgpUaGFua3MsCmRyZXcKCi0tIAprdm0tcmlzY3YgbWFpbGluZyBsaXN0Cmt2bS1yaXNj dkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8va3ZtLXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86CFB12CDA5 for ; Thu, 24 Apr 2025 14:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745503679; cv=none; b=UHpdLH5vCpM/IGF9KAZfQfpQPIiCoihNxwee06MDEghsYc1XNTyCY5uzvN9a64/D3EiR6oa04rgIHUs8sWqUm4+fgYfn5KNRw5hDeVq3xHj9xY96CTqJdZnXNSykAKGP45rC5BSEq+BGPR3ljejCFy82LaQB2wSR3W96dOBnE0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745503679; c=relaxed/simple; bh=Mee2OZD1lraRPPalIBE6iLcH6n6PqLWZrU1Z2lk9bFM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qma3MlH1QoGvkF/0mKPuy0BXITFXne9FUwEHe1gYMUzw7HzuVr65mRvwVnLfe/eABoXEg7F/11nEj6GG4uYcu3c4ss42BTkGwFQLYr7EOCBsySvG9SzDaT6tkun4roAGV+UD511tKRHqIXF5xGzn0TYojCgaj+LGJXkYxPdzRUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=T2lsnBvz; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="T2lsnBvz" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43d04dc73b7so9554025e9.3 for ; Thu, 24 Apr 2025 07:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1745503676; x=1746108476; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=U0v6f9lKAMd35DpCsKVbL9D2wBml6curMV8py2v4cGU=; b=T2lsnBvzTEvD8AfwzcF1X+hQ3nhMbw3pBj55HCGYtCSAKrcwkKKbnbCg3su91RFQvW p4a7dq86Qsbf9nearJDc9E7RRHPQJuBD/0VYCsZxUhGWjolZrXE2Qyvo7R+vKgc1Fvbt 4P6CgZbaUllEZfcZlVInXhGescIJXmhIo6t1RC1lkvmSSp8Xj3TFc/D5KpdnhwP4fDDx 3KzAghaXWeFLXcp9nz5+iX/RTZWzA+5q+nfY566xys9NwlGoLBsy02iYWI69HmprD6zo oAanvCMBuxIptNCaoUjkpZQkDlLgPW+ZDC5/dIDi9DRWwk74w+00ATjh+nifjZSbAmWh MPIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745503676; x=1746108476; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U0v6f9lKAMd35DpCsKVbL9D2wBml6curMV8py2v4cGU=; b=dfU8FI9I65xIxWFZwEzDFH7roVjqUDRYTVjb0XkYZ7r8LcD7FWJR6Uv+YBysrnTlNs iLaLOd77jukek/Gki5tqonX5A3fXObWOhwRwR0iF1TDMwGUuTL92glJm1YEkpIqrjsKQ pT7RQoNZEHlWmphwYIz1ftzT7irGZ95zoIXYIhhgxnxtQ0WfuUobxTUPgXSARPt4JCYe UxPXoqdEnPLGGKof/iztwtOYAertUS7gLT//Wvf4P9THD2GE73zucrKEuyFbHAQNr+OM O6hNGbE+3rnKZZ284UWEWyyOgxLC7Ycm8R/5g64m+iOEy8MYBWzJFDxsOhTKFEtr0Tst 3GoQ== X-Forwarded-Encrypted: i=1; AJvYcCWa5eF+Vnp2HnV2im30dgOtfdQXdpmsozrDvQDcmsleU7I6GzlussMWrX7gEJGnIi3CVps=@vger.kernel.org X-Gm-Message-State: AOJu0Yzw0VJhbiM1RRUHARHHG/3vK394qgH4B5pcEr2WU/2u9S40jln6 X6pq5PH7sEGxe1ou0Wi5rEemM8OWWqGwZsiTKwGN0+VOegM8GmloOcF66No5ay0= X-Gm-Gg: ASbGncvck1/uYRANXWBJwtdXnl5oaGQZH56Monh1fjtYvXepydXt1of7Wqcjl1I17CG 2BHMHJuFxHl5YpFdnphngPn2r/SXIhS3jrq6WEYiRw0kKQbB2q1RczXmeHhqeI58vgXdE68S46p UUvT0bK85I3y9siwfW3JElHg6bVacHjwxGqoht4TPyJwO3hfQv2hBv1UVQjgAxWco0xOHTYwLPo fRVI/q0JzAiTd2hF/McqUmruSldVkzKYTx0arKMuPtNmlEtUb1fMxUAmBiboI8JwdHQ6u7YVFg2 0arDJ95KDTQ8uphbD2RwO5WLQj1WXUo6gpxLtx0= X-Google-Smtp-Source: AGHT+IFUPMtP/KjaYEN9MtbB/NYTf0ZhorBZP9X4u5pu7YG//9ef9TT7MFoljX3EChphPUpWA7o/8A== X-Received: by 2002:a05:600c:a00d:b0:43d:7588:6688 with SMTP id 5b1f17b1804b1-4409bd18492mr27593225e9.12.1745503675515; Thu, 24 Apr 2025 07:07:55 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::f716]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2ac27dsm22476585e9.22.2025.04.24.07.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 07:07:55 -0700 (PDT) Date: Thu, 24 Apr 2025 16:07:54 +0200 From: Andrew Jones To: Anup Patel Cc: Will Deacon , julien.thierry.kdev@gmail.com, maz@kernel.org, Paolo Bonzini , Atish Patra , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org Subject: Re: [kvmtool PATCH 10/10] riscv: Allow including extensions in the min CPU type using command-line Message-ID: <20250424-153e6b09d5f0ccdee057a0d9@orel> References: <20250326065644.73765-1-apatel@ventanamicro.com> <20250326065644.73765-11-apatel@ventanamicro.com> <20250412-bc81866c2227ed98429f86b5@orel> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Apr 24, 2025 at 07:02:18PM +0530, Anup Patel wrote: > On Sat, Apr 12, 2025 at 7:15 PM Andrew Jones wrote: > > > bool riscv__isa_extension_disabled(struct kvm *kvm, unsigned long isa_ext_id) > > > { > > > struct isa_ext_info *info = NULL; > > > @@ -128,16 +142,39 @@ bool riscv__isa_extension_disabled(struct kvm *kvm, unsigned long isa_ext_id) > > > int riscv__cpu_type_parser(const struct option *opt, const char *arg, int unset) > > > { > > > struct kvm *kvm = opt->ptr; > > > + const char *str, *nstr; > > > + int len; > > > > > > - if ((strncmp(arg, "min", 3) && strncmp(arg, "max", 3)) || strlen(arg) != 3) > > > + if ((strncmp(arg, "min", 3) || strlen(arg) < 3) && > > > > If arg == 'min', then it can't be less than 3 so the '|| strlen(arg) < 3' > > is dead code. > > > > > + (strncmp(arg, "max", 3) || strlen(arg) != 3)) > > > > I think we want > > > > if (strlen(arg) < 3 || > > (strlen(arg) == 3 && strcmp(arg, "min") && strcmp(arg, "max")) || > > strncmp(arg, "min", 3)) > > Nope, for cpu-type = "min" the strlen(arg) can be greater than 3 > because of comma separated extensions provided as part of > cpu-type value. That's what the last condition 'strncmp(arg, "min", 3)' of my proposed compound-condition is confirming. That condition is only checked for strlen(arg) > 3. Thanks, drew