Re: [PATCH 5/5] arm64: dts: allwinner: t527: add EMAC0 to Avaoto-A1 board

[Andre Przywara <andre.przywara@arm.com>]

On Wed, 23 Apr 2025 22:03:26 +0800
Yixun Lan <dlan@gentoo.org> wrote:

Hi,

> On Avaoto A1 board, the EMAC0 connect to an external RTL8211F-CG PHY,

The name would be "Avaota" A1 board.

> which features a 25MHz crystal, and using PH8 pin as PHY reset.
> 
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
> ---
> I don't own this board, only compose this patch according to the
> schematics. Let me know if it works.
> ---
>  arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts b/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
> index 85a546aecdbe149d6bad10327fca1fb7dafff6ad..23ab89c742c679fb274babbb0205f119eb2c9baa 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
> @@ -64,6 +64,23 @@ &ehci1 {
>  	status = "okay";
>  };

As for the Radxa board, we need an alias for ethernet0.

>  
> +&emac0 {
> +	phy-mode = "rgmii";

As Andrew mentioned, this should probably be "rgmii-id".

> +	phy-handle = <&ext_rgmii_phy>;

Can you please add the phy-supply here, it's reg_dcdc4.

Cheers,
Andre

> +
> +	allwinner,tx-delay-ps = <100>;
> +	allwinner,rx-delay-ps = <300>;
> +
> +	status = "okay";
> +};
> +
> +&mdio0 {
> +	ext_rgmii_phy: ethernet-phy@1 {
> +		compatible = "ethernet-phy-ieee802.3-c22";
> +		reg = <1>;
> +	};
> +};
> +
>  &mmc0 {
>  	vmmc-supply = <&reg_cldo3>;
>  	cd-gpios = <&pio 5 6 (GPIO_ACTIVE_LOW | GPIO_PULL_DOWN)>; /* PF6 */
>