From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69055C369D8 for ; Thu, 24 Apr 2025 09:56:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BAE2410E7AD; Thu, 24 Apr 2025 09:56:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="KEqN75eq"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE9D610E7A5; Thu, 24 Apr 2025 09:56:11 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 29EE0A4BD97; Thu, 24 Apr 2025 09:50:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A239EC4CEEB; Thu, 24 Apr 2025 09:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745488571; bh=KwTxUWB8eoY1enwOmL1Rz7TnjVwHUrW7NjL5EDBhkRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KEqN75eqyoVVKaygRATIKVaTzIYqoNMjVzyvM+liC+gY5iTMuVg9bK6KI/4CLxIxL 1XQiTOUQocxaJLcGFUZIa9c7PfQJXaB4brw2ZXtH62uKWsiMTXrSs/a6RhRgrZVrTL OVdtXZABxPyNw4QCqjTHnTkTztBNk7VobZAjIvGeBLTDclf8nywqFCyP58FC87RnPy HXOt/+FL/ukQUKD6T4JTD4oqA2h/E31zqN+az/YBYmbLGJdm9ZUfra3+KA7Cjh+HCH MMmx6c9PnIdm1FF8LLmHAYfZiKfaGkJWJIxOs2uA4DkWHhRDFZbOKBLj5jAeo25SBp vW3wInHd7NWgA== From: Philipp Stanner To: Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Matthew Brost , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/6] drm/sched: Warn if pending list is not empty Date: Thu, 24 Apr 2025 11:55:33 +0200 Message-ID: <20250424095535.26119-5-phasta@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250424095535.26119-2-phasta@kernel.org> References: <20250424095535.26119-2-phasta@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Signed-off-by: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index c2ad6c70bfb6..0c56b85c574f 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -1457,6 +1457,9 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched) sched->ready = false; kfree(sched->sched_rq); sched->sched_rq = NULL; + + if (!list_empty(&sched->pending_list)) + dev_err(sched->dev, "Tearing down scheduler while jobs are pending!\n"); } EXPORT_SYMBOL(drm_sched_fini); -- 2.48.1