Re: [LTP] [PATCH] unshare03: use sizeof(long long) to fix for 32bit

[Petr Vorel <pvorel@suse.cz>]

Hi Avinesh,

> when executing on 32bit compat layer
> "nr_open = sizeof(long) * 8" does not evaluate to a large enough value
> for /proc/sys/fs/nr_open.
> unshare03.c:38: TBROK: Failed to close FILE '/proc/sys/fs/nr_open': EINVAL (22)
> Use (long long) instead.

> Fixes: fc8be6ed4 ("unshare03: Simplify EMFILE test by using fixed fd limit (sizeof(long) * 8)")
> Suggested-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Avinesh Kumar <akumar@suse.de>
> ---
>  testcases/kernel/syscalls/unshare/unshare03.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/kernel/syscalls/unshare/unshare03.c b/testcases/kernel/syscalls/unshare/unshare03.c
> index c3b98930d..7128b3b97 100644
> --- a/testcases/kernel/syscalls/unshare/unshare03.c
> +++ b/testcases/kernel/syscalls/unshare/unshare03.c
> @@ -27,7 +27,7 @@ static void run(void)
>  		.exit_signal = SIGCHLD,
>  	};

> -	int nr_open = sizeof(long) * 8;
> +	int nr_open = sizeof(long long) * 8;

Thank you!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp