From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 549EFC369AB for ; Thu, 24 Apr 2025 12:24:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC2A010E31C; Thu, 24 Apr 2025 12:24:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="AwMt9hiz"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDE1710E31C for ; Thu, 24 Apr 2025 12:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1745497463; bh=EPY4acWajNcExtL2mcawm0yfatLm/mqsxg6yAKcSxr4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AwMt9hizlsUfdTJa22FZiJuTZaWs5y7Pq9Ov9K8ft1YhS2qaotOIhTNyTQwysKZlm QRzX9q1Li8BeZeBQbzr9o5QIqlwcBjfMrdVUNQsbBzt5Sh+r1EDFIDl2Au7zbWcADS dXxfGflQ7Dr+Tgk5ccJlW0vJIMa46rWTaQ+GbrIqu3v3nCzCr+W9M7LaWHf9PTj47J D/t1OAKQ1w12LqLGJatGVgQrRCzrcRLbKyrBCgeUbutUY8kLZ4x9CTB9uePE4CrM2t EKhozYI+i823fwXoJdPoir4Ls1fffTm26pgnhV0jihtzIjkji/D920CpJFy60om/nN +T6soN5qS+WTA== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4F18317E3610; Thu, 24 Apr 2025 14:24:23 +0200 (CEST) Date: Thu, 24 Apr 2025 14:24:19 +0200 From: Boris Brezillon To: "Arnd Bergmann" Cc: "Arnd Bergmann" , "Steven Price" , "Liviu Dudau" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Dave Airlie" , "Simona Vetter" , =?UTF-8?B?QWRyacOhbg==?= Larumbe , "Dmitry Osipenko" , "Florent Tomasin" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panthor: fix building without CONFIG_DEBUG_FS Message-ID: <20250424142419.47b9d457@collabora.com> In-Reply-To: <41cd0579-698c-4e1e-82c4-3d46a1cd5e3e@app.fastmail.com> References: <20250424112637.3432563-1-arnd@kernel.org> <20250424134105.087ec2f8@collabora.com> <41cd0579-698c-4e1e-82c4-3d46a1cd5e3e@app.fastmail.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 24 Apr 2025 14:10:16 +0200 "Arnd Bergmann" wrote: > On Thu, Apr 24, 2025, at 13:41, Boris Brezillon wrote: > > On Thu, 24 Apr 2025 13:25:47 +0200 > >> +#ifdef CONFIG_DEBUG_FS > >> bo->debugfs.flags = usage_flags | PANTHOR_DEBUGFS_GEM_USAGE_FLAG_INITIALIZED; > >> -} > >> - > >> -#else > >> -void panthor_gem_debugfs_set_usage_flags(struct panthor_gem_object *bo, u32 usage_flags) {}; > >> #endif > >> +} > >> > > > > Oops. I actually don't see a good reason to expose this function, so > > could we go for something like that instead? > > I think moving it into pantor_gem.c makes sense, and it certainly > avoids the build warning. > > > #else > > static void panthor_gem_debugfs_bo_add(struct panthor_device *ptdev, > > struct panthor_gem_object *bo) > > {} > > static void panthor_gem_debugfs_bo_rm(struct panthor_gem_object *bo) {} > > +static void panthor_gem_debugfs_set_usage_flags(struct > > panthor_gem_object *bo, > > + u32 usage_flags) > > +{ > > Side note: I think the panthor_gem_debugfs_bo_{add,rm} stubs could > actually be replaced with an IS_ENABLED() check in the normal > functions, but that wouldn't work for > panthor_gem_debugfs_set_usage_flags or > panthor_gem_debugfs_print_bos(). Yeah, I think I prefer consistency over saving a few LoC ;-). Do you plan to send a v2 with the suggested changes, or should we take care of that?