From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH 3/3] selftests/bpf: Fix endianness issue in __qspinlock declaration
Date: Thu, 24 Apr 2025 18:41:27 +0200 [thread overview]
Message-ID: <20250424165525.154403-4-iii@linux.ibm.com> (raw)
In-Reply-To: <20250424165525.154403-1-iii@linux.ibm.com>
Copy the big-endian field declarations from qspinlock_types.h,
otherwise some properties won't hold on big-endian systems. For
example, assigning lock->val = 1 should result in lock->locked == 1,
which is not the case there.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
.../selftests/bpf/progs/bpf_arena_spin_lock.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tools/testing/selftests/bpf/progs/bpf_arena_spin_lock.h b/tools/testing/selftests/bpf/progs/bpf_arena_spin_lock.h
index 4e29c31c4ef8..d67466c1ff77 100644
--- a/tools/testing/selftests/bpf/progs/bpf_arena_spin_lock.h
+++ b/tools/testing/selftests/bpf/progs/bpf_arena_spin_lock.h
@@ -32,6 +32,7 @@ extern unsigned long CONFIG_NR_CPUS __kconfig;
struct __qspinlock {
union {
atomic_t val;
+#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
struct {
u8 locked;
u8 pending;
@@ -40,6 +41,17 @@ struct __qspinlock {
u16 locked_pending;
u16 tail;
};
+#else
+ struct {
+ u16 tail;
+ u16 locked_pending;
+ };
+ struct {
+ u8 reserved[2];
+ u8 pending;
+ u8 locked;
+ };
+#endif
};
};
--
2.49.0
next prev parent reply other threads:[~2025-04-24 16:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 16:41 [PATCH 0/3] selftests/bpf: Fix a few issues in arena_spin_lock Ilya Leoshkevich
2025-04-24 16:41 ` [PATCH 1/3] selftests/bpf: Fix arena_spin_lock.c build dependency Ilya Leoshkevich
2025-04-24 16:41 ` [PATCH 2/3] selftests/bpf: Fix arena_spin_lock on systems with less than 16 CPUs Ilya Leoshkevich
2025-04-24 16:41 ` Ilya Leoshkevich [this message]
2025-04-24 18:33 ` [PATCH 0/3] selftests/bpf: Fix a few issues in arena_spin_lock patchwork-bot+netdevbpf
2025-04-24 18:41 ` Alexei Starovoitov
2025-04-24 18:51 ` Konstantin Ryabitsev
2025-04-25 16:25 ` Jakub Kicinski
2025-04-25 17:18 ` Konstantin Ryabitsev
2025-04-25 18:58 ` Konstantin Ryabitsev
2025-04-26 0:32 ` Alexei Starovoitov
2025-04-25 0:10 ` patchwork-bot+netdevbpf
2025-04-25 0:16 ` Alexei Starovoitov
2025-04-25 0:40 ` patchwork-bot+netdevbpf
2025-04-25 1:14 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424165525.154403-4-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.