All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android16-6.12 0/1] drivers/misc/uid_sys_stats.c:508:41: error: lvalue required as unary '&' operand
Date: Fri, 25 Apr 2025 09:51:45 +0800	[thread overview]
Message-ID: <202504250934.hSCsFNAt-lkp@intel.com> (raw)

tree:   https://android.googlesource.com/kernel/common android16-6.12
head:   b01e71951e32bcf55e252da941d55692247d1a5c
commit: 5f450572c83a34b6fb1936b8330f738e48e1d966 [0/1] ANDROID: uid_sys_stats: add ANDROID_OEM_DATA in struct uid_entry and update_stats_work
config: i386-randconfig-052-20250424 (https://download.01.org/0day-ci/archive/20250425/202504250934.hSCsFNAt-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504250934.hSCsFNAt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504250934.hSCsFNAt-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/misc/uid_sys_stats.c: In function 'update_stats_workfn':
>> drivers/misc/uid_sys_stats.c:508:41: error: lvalue required as unary '&' operand
     508 |                 UPDATE_ANDROID_OEM_DATA(&OEM_DATA(uid_entry),
         |                                         ^
   drivers/misc/uid_sys_stats.c:52:43: note: in definition of macro 'UPDATE_ANDROID_OEM_DATA'
      52 |         trace_android_vh_update_uid_stats(target, source, task, type)
         |                                           ^~~~~~
   drivers/misc/uid_sys_stats.c:509:25: error: lvalue required as unary '&' operand
     509 |                         &OEM_DATA(usw), NULL, 0);
         |                         ^
   drivers/misc/uid_sys_stats.c:52:51: note: in definition of macro 'UPDATE_ANDROID_OEM_DATA'
      52 |         trace_android_vh_update_uid_stats(target, source, task, type)
         |                                                   ^~~~~~
   drivers/misc/uid_sys_stats.c: In function 'process_notifier':
   drivers/misc/uid_sys_stats.c:547:55: error: lvalue required as unary '&' operand
     547 |                         UPDATE_ANDROID_OEM_DATA(NULL, &OEM_DATA(usw), task, 1);
         |                                                       ^
   drivers/misc/uid_sys_stats.c:52:51: note: in definition of macro 'UPDATE_ANDROID_OEM_DATA'
      52 |         trace_android_vh_update_uid_stats(target, source, task, type)
         |                                                   ^~~~~~
   drivers/misc/uid_sys_stats.c:563:33: error: lvalue required as unary '&' operand
     563 |         UPDATE_ANDROID_OEM_DATA(&OEM_DATA(uid_entry), NULL, task, 2);
         |                                 ^
   drivers/misc/uid_sys_stats.c:52:43: note: in definition of macro 'UPDATE_ANDROID_OEM_DATA'
      52 |         trace_android_vh_update_uid_stats(target, source, task, type)
         |                                           ^~~~~~


vim +508 drivers/misc/uid_sys_stats.c

   491	
   492	static void update_stats_workfn(struct work_struct *work)
   493	{
   494		struct update_stats_work *usw, *t;
   495		struct uid_entry *uid_entry;
   496		struct task_entry *task_entry __maybe_unused;
   497		struct llist_node *node;
   498	
   499		node = llist_del_all(&work_usw);
   500		llist_for_each_entry_safe(usw, t, node, node) {
   501			lock_uid(usw->uid);
   502			uid_entry = find_uid_entry(usw->uid);
   503			if (!uid_entry)
   504				goto next;
   505	
   506			uid_entry->utime += usw->utime;
   507			uid_entry->stime += usw->stime;
 > 508			UPDATE_ANDROID_OEM_DATA(&OEM_DATA(uid_entry),
   509				&OEM_DATA(usw), NULL, 0);
   510	
   511			__add_uid_io_stats(uid_entry, &usw->ioac, UID_STATE_DEAD_TASKS);
   512	next:
   513			unlock_uid(usw->uid);
   514			kfree(usw);
   515		}
   516	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-04-25  1:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202504250934.hSCsFNAt-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.