From: Andre Przywara <andre.przywara@arm.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Chukun Pan <amadeus@jmu.edu.cn>, <dlan@gentoo.org>,
<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<jernej.skrabec@gmail.com>, <krzk+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-sunxi@lists.linux.dev>,
<robh@kernel.org>, <samuel@sholland.org>
Subject: Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E
Date: Fri, 25 Apr 2025 10:46:14 +0100 [thread overview]
Message-ID: <20250425104614.7efdd6c1@donnerap.manchester.arm.com> (raw)
In-Reply-To: <CAGb2v649ntfAEUdV5S1wM8nUGhvaOP-RBw07XcxwdbafbC2PYQ@mail.gmail.com>
On Fri, 25 Apr 2025 11:52:42 +0800
Chen-Yu Tsai <wens@csie.org> wrote:
> On Fri, Apr 25, 2025 at 11:00 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
> >
> > Hi,
> >
> > > It seems I'm a little bit late for this, but while we are here,
> > > Can we also append 'cubie' to dts file name?
> > > e.g. - sun55i-a527-radxa-cubie-a5e.dts
> >
> > Usually we use the device name (without the vendor name),
> > maybe sun55i-a527-cubie-a5e.dts would be better?
>
> I agree with this one.
>
> I can probably squash in a name change (since I'll be squashing in the
> SD card slot fix anyway). Andre?
Yes, I noticed that yesterday as well. So that's fine with me: both the
name change and the squash.
Cheers,
Andre
> In that case would you prefer to keep your current patch separate, or
> squashed in so that everything is clean from the first commit?
>
> It's up to you since you lose out on commit stats.
>
>
> Thanks
> ChenYu
>
> > Thanks,
> > Chukun
> >
> > --
> > 2.25.1
> >
> >
prev parent reply other threads:[~2025-04-25 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 10:00 [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E Chukun Pan
2025-04-16 10:11 ` Andre Przywara
2025-04-24 17:52 ` Chen-Yu Tsai
2025-04-25 2:35 ` Yixun Lan
2025-04-25 3:00 ` Chukun Pan
2025-04-25 3:52 ` Chen-Yu Tsai
2025-04-25 4:47 ` Yixun Lan
2025-04-25 15:27 ` Chen-Yu Tsai
2025-04-25 9:46 ` Andre Przywara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425104614.7efdd6c1@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.