From: Johannes Weiner <hannes@cmpxchg.org>
To: Wenchao Hao <haowenchao22@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/compaction: do not break pages whose order is larger than target order
Date: Fri, 25 Apr 2025 11:32:32 -0400 [thread overview]
Message-ID: <20250425153232.GA108388@cmpxchg.org> (raw)
In-Reply-To: <CAOptpSPoc76ZSzbKJSnnfxtcDubJHC8a1zU7b=C=wdF6_wC3ww@mail.gmail.com>
On Fri, Apr 25, 2025 at 10:28:42PM +0800, Wenchao Hao wrote:
> On Fri, Apr 25, 2025 at 3:42 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
> >
> > On Thu, Apr 24, 2025 at 11:38:15PM +0800, Wenchao Hao wrote:
> > > When scanning free pages for memory compaction, if the compaction target
> > > order is explicitly specified, do not split pages in buddy whose order
> > > are larger than compaction target order.
> >
> > Have you observed this to be an issue in practice?
> >
> > compact_finished() would have bailed if such a page had existed.
> >
>
> Yes, when proactive memory compaction is enabled, there may be situations
> where the order of isolated free pages is greater than the compaction
> requested order, and compact_finished() will return continue.
proactive compaction has an order of -1?
next prev parent reply other threads:[~2025-04-25 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 15:38 [PATCH] mm/compaction: do not break pages whose order is larger than target order Wenchao Hao
2025-04-24 19:42 ` Johannes Weiner
2025-04-25 14:28 ` Wenchao Hao
2025-04-25 15:32 ` Johannes Weiner [this message]
2025-04-25 17:24 ` Wenchao Hao
2025-04-29 16:44 ` Zi Yan
2025-04-25 6:53 ` Baolin Wang
2025-04-25 14:57 ` Wenchao Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425153232.GA108388@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=haowenchao22@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.