From: Denys Dmytriyenko <denis@denix.org>
To: Chirag Shilwant <c-shilwant@ti.com>
Cc: meta-ti@lists.yoctoproject.org, Ryan Eatmon <reatmon@ti.com>,
Andrew <afd@ti.com>, Neha <n-francis@ti.com>
Subject: Re: [meta-ti][master/scarthgap][PATCH] recipes-bsp: u-boot: Fix PACKAGECONFIG[dm] arguments
Date: Sat, 26 Apr 2025 12:04:57 -0400 [thread overview]
Message-ID: <20250426160457.GN13634@denix.org> (raw)
In-Reply-To: <20250425204857.3271868-1-c-shilwant@ti.com>
On Sat, Apr 26, 2025 at 02:18:57AM +0530, Chirag Shilwant wrote:
> * As observed in the u-boot makefile [0][1], the argument
> anticipated by u-boot binman is "TI_DM" instead of "DM".
> Hence, fix the same in meta-ti-bsp.
Was it always "TI_DM", or was it "DM" initially in TI U-boot and later got
changed tp "TI_DM" in upstream?
> * The behavior went unnoticed until now because "ti-dm"
> was still being sourced from BINMAN_INDIRS, which referred
> to "ti-linux-firmware" and the PACKAGECONFIG[dm] feature
> was redundant.
>
> [0]: https://github.com/u-boot/u-boot/blob/v2025.01/Makefile#L1408
>
> [1]: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/Makefile?h=ti-u-boot-2025.01#n1409
>
> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
> ---
> meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> index 9a74b840..e337f84f 100644
> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> @@ -63,7 +63,7 @@ PLAT_SFX:am62pxx = "am62pxx"
> PACKAGECONFIG[ap-trusted-rom] = "BL1=${STAGING_DIR_HOST}/firmware/bl1.bin,,trusted-firmware-a"
> PACKAGECONFIG[atf] = "BL31=${STAGING_DIR_HOST}/firmware/bl31.bin,,trusted-firmware-a"
> PACKAGECONFIG[optee] = "TEE=${STAGING_DIR_HOST}${nonarch_base_libdir}/firmware/bl32.bin,,optee-os"
> -PACKAGECONFIG[dm] = "DM=${STAGING_DIR_HOST}${nonarch_base_libdir}/firmware/ti-dm/${PLAT_SFX}/${DM_FIRMWARE},,ti-dm-fw"
> +PACKAGECONFIG[dm] = "TI_DM=${STAGING_DIR_HOST}${nonarch_base_libdir}/firmware/ti-dm/${PLAT_SFX}/${DM_FIRMWARE},,ti-dm-fw"
>
> PACKAGECONFIG:append:aarch64 = " atf optee"
> PACKAGECONFIG:append:j721e = " dm"
> --
> 2.34.1
next prev parent reply other threads:[~2025-04-26 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 20:48 [meta-ti][master/scarthgap][PATCH] recipes-bsp: u-boot: Fix PACKAGECONFIG[dm] arguments Chirag Shilwant
2025-04-25 21:31 ` Andrew Davis
2025-04-26 16:04 ` Denys Dmytriyenko [this message]
2025-04-28 8:48 ` Chirag Shilwant
2025-04-28 14:12 ` Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250426160457.GN13634@denix.org \
--to=denis@denix.org \
--cc=afd@ti.com \
--cc=c-shilwant@ti.com \
--cc=meta-ti@lists.yoctoproject.org \
--cc=n-francis@ti.com \
--cc=reatmon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.