Re: [RFC v4 14/16] drm/sched: Remove FIFO and RR and simplify to a single run queue

[kernel test robot <lkp@intel.com>]

Hi Tvrtko,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-exynos/exynos-drm-next]
[also build test WARNING on next-20250424]
[cannot apply to linus/master drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip v6.15-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tvrtko-Ursulin/drm-sched-Add-some-scheduling-quality-unit-tests/20250425-182308
base:   https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
patch link:    https://lore.kernel.org/r/20250425102034.85133-15-tvrtko.ursulin%40igalia.com
patch subject: [RFC v4 14/16] drm/sched: Remove FIFO and RR and simplify to a single run queue
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250426/202504262023.i6ivlVLT-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504262023.i6ivlVLT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504262023.i6ivlVLT-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/scheduler/sched_rq.c:97: warning: Excess function parameter 'ts' description in 'drm_sched_rq_add_entity'


vim +97 drivers/gpu/drm/scheduler/sched_rq.c

ad770215b9e61e Tvrtko Ursulin 2025-04-25   84  
492894e6853b94 Tvrtko Ursulin 2025-04-25   85  /**
492894e6853b94 Tvrtko Ursulin 2025-04-25   86   * drm_sched_rq_add_entity - add an entity
492894e6853b94 Tvrtko Ursulin 2025-04-25   87   *
492894e6853b94 Tvrtko Ursulin 2025-04-25   88   * @entity: scheduler entity
492894e6853b94 Tvrtko Ursulin 2025-04-25   89   * @ts: submission timestamp
492894e6853b94 Tvrtko Ursulin 2025-04-25   90   *
492894e6853b94 Tvrtko Ursulin 2025-04-25   91   * Adds a scheduler entity to the run queue.
492894e6853b94 Tvrtko Ursulin 2025-04-25   92   *
492894e6853b94 Tvrtko Ursulin 2025-04-25   93   * Returns a DRM scheduler pre-selected to handle this entity.
492894e6853b94 Tvrtko Ursulin 2025-04-25   94   */
492894e6853b94 Tvrtko Ursulin 2025-04-25   95  struct drm_gpu_scheduler *
a7ce3f10ad3c5d Tvrtko Ursulin 2025-04-25   96  drm_sched_rq_add_entity(struct drm_sched_entity *entity)
492894e6853b94 Tvrtko Ursulin 2025-04-25  @97  {
492894e6853b94 Tvrtko Ursulin 2025-04-25   98  	struct drm_gpu_scheduler *sched;
492894e6853b94 Tvrtko Ursulin 2025-04-25   99  	struct drm_sched_rq *rq;
a7ce3f10ad3c5d Tvrtko Ursulin 2025-04-25  100  	ktime_t ts;
492894e6853b94 Tvrtko Ursulin 2025-04-25  101  
492894e6853b94 Tvrtko Ursulin 2025-04-25  102  	/* Add the entity to the run queue */
492894e6853b94 Tvrtko Ursulin 2025-04-25  103  	spin_lock(&entity->lock);
492894e6853b94 Tvrtko Ursulin 2025-04-25  104  	if (entity->stopped) {
492894e6853b94 Tvrtko Ursulin 2025-04-25  105  		spin_unlock(&entity->lock);
492894e6853b94 Tvrtko Ursulin 2025-04-25  106  
492894e6853b94 Tvrtko Ursulin 2025-04-25  107  		DRM_ERROR("Trying to push to a killed entity\n");
492894e6853b94 Tvrtko Ursulin 2025-04-25  108  		return NULL;
492894e6853b94 Tvrtko Ursulin 2025-04-25  109  	}
492894e6853b94 Tvrtko Ursulin 2025-04-25  110  
492894e6853b94 Tvrtko Ursulin 2025-04-25  111  	rq = entity->rq;
492894e6853b94 Tvrtko Ursulin 2025-04-25  112  	spin_lock(&rq->lock);
492894e6853b94 Tvrtko Ursulin 2025-04-25  113  	sched = rq->sched;
492894e6853b94 Tvrtko Ursulin 2025-04-25  114  
492894e6853b94 Tvrtko Ursulin 2025-04-25  115  	if (list_empty(&entity->list)) {
492894e6853b94 Tvrtko Ursulin 2025-04-25  116  		atomic_inc(sched->score);
492894e6853b94 Tvrtko Ursulin 2025-04-25  117  		list_add_tail(&entity->list, &rq->entities);
492894e6853b94 Tvrtko Ursulin 2025-04-25  118  	}
492894e6853b94 Tvrtko Ursulin 2025-04-25  119  
ad770215b9e61e Tvrtko Ursulin 2025-04-25  120  	ts = drm_sched_rq_get_min_vruntime(rq);
ad770215b9e61e Tvrtko Ursulin 2025-04-25  121  	ts = drm_sched_entity_restore_vruntime(entity, ts);
a7ce3f10ad3c5d Tvrtko Ursulin 2025-04-25  122  	drm_sched_rq_update_tree_locked(entity, rq, ts);
492894e6853b94 Tvrtko Ursulin 2025-04-25  123  
492894e6853b94 Tvrtko Ursulin 2025-04-25  124  	spin_unlock(&rq->lock);
492894e6853b94 Tvrtko Ursulin 2025-04-25  125  	spin_unlock(&entity->lock);
492894e6853b94 Tvrtko Ursulin 2025-04-25  126  
492894e6853b94 Tvrtko Ursulin 2025-04-25  127  	return sched;
492894e6853b94 Tvrtko Ursulin 2025-04-25  128  }
492894e6853b94 Tvrtko Ursulin 2025-04-25  129  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki