From: kernel test robot <lkp@intel.com>
To: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Subject: Re: [PATCH v2 1/3] soc: qcom: socinfo: Add support for new fields in revision 20
Date: Sun, 27 Apr 2025 00:28:21 +0800 [thread overview]
Message-ID: <202504270011.Jftyvklb-lkp@intel.com> (raw)
In-Reply-To: <20250425135946.1087065-1-mukesh.ojha@oss.qualcomm.com>
Hi Mukesh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.15-rc3 next-20250424]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mukesh-Ojha/soc-qcom-socinfo-Add-support-for-new-fields-in-revision-21/20250425-220213
base: linus/master
patch link: https://lore.kernel.org/r/20250425135946.1087065-1-mukesh.ojha%40oss.qualcomm.com
patch subject: [PATCH v2 1/3] soc: qcom: socinfo: Add support for new fields in revision 20
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20250427/202504270011.Jftyvklb-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250427/202504270011.Jftyvklb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504270011.Jftyvklb-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/soc/qcom/socinfo.c: In function 'socinfo_debugfs_init':
>> drivers/soc/qcom/socinfo.c:613:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
613 | debugfs_create_u32("raw_package_type", 0444, qcom_socinfo->dbg_root,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
614 | &qcom_socinfo->info.raw_package_type);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:615:9: note: here
615 | case SOCINFO_VERSION(0, 19):
| ^~~~
vim +613 drivers/soc/qcom/socinfo.c
592
593 static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
594 struct socinfo *info, size_t info_size)
595 {
596 struct smem_image_version *versions;
597 struct dentry *dentry;
598 size_t size;
599 int i;
600 unsigned int num_pmics;
601 unsigned int pmic_array_offset;
602
603 qcom_socinfo->dbg_root = debugfs_create_dir("qcom_socinfo", NULL);
604
605 qcom_socinfo->info.fmt = __le32_to_cpu(info->fmt);
606
607 debugfs_create_x32("info_fmt", 0444, qcom_socinfo->dbg_root,
608 &qcom_socinfo->info.fmt);
609
610 switch (qcom_socinfo->info.fmt) {
611 case SOCINFO_VERSION(0, 20):
612 qcom_socinfo->info.raw_package_type = __le32_to_cpu(info->raw_package_type);
> 613 debugfs_create_u32("raw_package_type", 0444, qcom_socinfo->dbg_root,
614 &qcom_socinfo->info.raw_package_type);
615 case SOCINFO_VERSION(0, 19):
616 qcom_socinfo->info.num_func_clusters = __le32_to_cpu(info->num_func_clusters);
617 qcom_socinfo->info.boot_cluster = __le32_to_cpu(info->boot_cluster);
618 qcom_socinfo->info.boot_core = __le32_to_cpu(info->boot_core);
619
620 debugfs_create_u32("num_func_clusters", 0444, qcom_socinfo->dbg_root,
621 &qcom_socinfo->info.num_func_clusters);
622 debugfs_create_u32("boot_cluster", 0444, qcom_socinfo->dbg_root,
623 &qcom_socinfo->info.boot_cluster);
624 debugfs_create_u32("boot_core", 0444, qcom_socinfo->dbg_root,
625 &qcom_socinfo->info.boot_core);
626 fallthrough;
627 case SOCINFO_VERSION(0, 18):
628 case SOCINFO_VERSION(0, 17):
629 qcom_socinfo->info.oem_variant = __le32_to_cpu(info->oem_variant);
630 debugfs_create_u32("oem_variant", 0444, qcom_socinfo->dbg_root,
631 &qcom_socinfo->info.oem_variant);
632 fallthrough;
633 case SOCINFO_VERSION(0, 16):
634 qcom_socinfo->info.feature_code = __le32_to_cpu(info->feature_code);
635 qcom_socinfo->info.pcode = __le32_to_cpu(info->pcode);
636
637 debugfs_create_u32("feature_code", 0444, qcom_socinfo->dbg_root,
638 &qcom_socinfo->info.feature_code);
639 debugfs_create_u32("pcode", 0444, qcom_socinfo->dbg_root,
640 &qcom_socinfo->info.pcode);
641 fallthrough;
642 case SOCINFO_VERSION(0, 15):
643 qcom_socinfo->info.nmodem_supported = __le32_to_cpu(info->nmodem_supported);
644
645 debugfs_create_u32("nmodem_supported", 0444, qcom_socinfo->dbg_root,
646 &qcom_socinfo->info.nmodem_supported);
647 fallthrough;
648 case SOCINFO_VERSION(0, 14):
649 qcom_socinfo->info.num_clusters = __le32_to_cpu(info->num_clusters);
650 qcom_socinfo->info.ncluster_array_offset = __le32_to_cpu(info->ncluster_array_offset);
651 qcom_socinfo->info.num_subset_parts = __le32_to_cpu(info->num_subset_parts);
652 qcom_socinfo->info.nsubset_parts_array_offset =
653 __le32_to_cpu(info->nsubset_parts_array_offset);
654
655 debugfs_create_u32("num_clusters", 0444, qcom_socinfo->dbg_root,
656 &qcom_socinfo->info.num_clusters);
657 debugfs_create_u32("ncluster_array_offset", 0444, qcom_socinfo->dbg_root,
658 &qcom_socinfo->info.ncluster_array_offset);
659 debugfs_create_u32("num_subset_parts", 0444, qcom_socinfo->dbg_root,
660 &qcom_socinfo->info.num_subset_parts);
661 debugfs_create_u32("nsubset_parts_array_offset", 0444, qcom_socinfo->dbg_root,
662 &qcom_socinfo->info.nsubset_parts_array_offset);
663 fallthrough;
664 case SOCINFO_VERSION(0, 13):
665 qcom_socinfo->info.nproduct_id = __le32_to_cpu(info->nproduct_id);
666
667 debugfs_create_u32("nproduct_id", 0444, qcom_socinfo->dbg_root,
668 &qcom_socinfo->info.nproduct_id);
669 DEBUGFS_ADD(info, chip_id);
670 fallthrough;
671 case SOCINFO_VERSION(0, 12):
672 qcom_socinfo->info.chip_family =
673 __le32_to_cpu(info->chip_family);
674 qcom_socinfo->info.raw_device_family =
675 __le32_to_cpu(info->raw_device_family);
676 qcom_socinfo->info.raw_device_num =
677 __le32_to_cpu(info->raw_device_num);
678
679 debugfs_create_x32("chip_family", 0444, qcom_socinfo->dbg_root,
680 &qcom_socinfo->info.chip_family);
681 debugfs_create_x32("raw_device_family", 0444,
682 qcom_socinfo->dbg_root,
683 &qcom_socinfo->info.raw_device_family);
684 debugfs_create_x32("raw_device_number", 0444,
685 qcom_socinfo->dbg_root,
686 &qcom_socinfo->info.raw_device_num);
687 fallthrough;
688 case SOCINFO_VERSION(0, 11):
689 num_pmics = le32_to_cpu(info->num_pmics);
690 pmic_array_offset = le32_to_cpu(info->pmic_array_offset);
691 if (pmic_array_offset + 2 * num_pmics * sizeof(u32) <= info_size)
692 DEBUGFS_ADD(info, pmic_model_array);
693 fallthrough;
694 case SOCINFO_VERSION(0, 10):
695 case SOCINFO_VERSION(0, 9):
696 qcom_socinfo->info.foundry_id = __le32_to_cpu(info->foundry_id);
697
698 debugfs_create_u32("foundry_id", 0444, qcom_socinfo->dbg_root,
699 &qcom_socinfo->info.foundry_id);
700 fallthrough;
701 case SOCINFO_VERSION(0, 8):
702 case SOCINFO_VERSION(0, 7):
703 DEBUGFS_ADD(info, pmic_model);
704 DEBUGFS_ADD(info, pmic_die_rev);
705 fallthrough;
706 case SOCINFO_VERSION(0, 6):
707 qcom_socinfo->info.hw_plat_subtype =
708 __le32_to_cpu(info->hw_plat_subtype);
709
710 debugfs_create_u32("hardware_platform_subtype", 0444,
711 qcom_socinfo->dbg_root,
712 &qcom_socinfo->info.hw_plat_subtype);
713 fallthrough;
714 case SOCINFO_VERSION(0, 5):
715 qcom_socinfo->info.accessory_chip =
716 __le32_to_cpu(info->accessory_chip);
717
718 debugfs_create_u32("accessory_chip", 0444,
719 qcom_socinfo->dbg_root,
720 &qcom_socinfo->info.accessory_chip);
721 fallthrough;
722 case SOCINFO_VERSION(0, 4):
723 qcom_socinfo->info.plat_ver = __le32_to_cpu(info->plat_ver);
724
725 debugfs_create_u32("platform_version", 0444,
726 qcom_socinfo->dbg_root,
727 &qcom_socinfo->info.plat_ver);
728 fallthrough;
729 case SOCINFO_VERSION(0, 3):
730 qcom_socinfo->info.hw_plat = __le32_to_cpu(info->hw_plat);
731
732 debugfs_create_u32("hardware_platform", 0444,
733 qcom_socinfo->dbg_root,
734 &qcom_socinfo->info.hw_plat);
735 fallthrough;
736 case SOCINFO_VERSION(0, 2):
737 qcom_socinfo->info.raw_ver = __le32_to_cpu(info->raw_ver);
738
739 debugfs_create_u32("raw_version", 0444, qcom_socinfo->dbg_root,
740 &qcom_socinfo->info.raw_ver);
741 fallthrough;
742 case SOCINFO_VERSION(0, 1):
743 DEBUGFS_ADD(info, build_id);
744 break;
745 }
746
747 versions = qcom_smem_get(QCOM_SMEM_HOST_ANY, SMEM_IMAGE_VERSION_TABLE,
748 &size);
749
750 for (i = 0; i < ARRAY_SIZE(socinfo_image_names); i++) {
751 if (!socinfo_image_names[i])
752 continue;
753
754 dentry = debugfs_create_dir(socinfo_image_names[i],
755 qcom_socinfo->dbg_root);
756 debugfs_create_file("name", 0444, dentry, &versions[i],
757 &qcom_image_name_ops);
758 debugfs_create_file("variant", 0444, dentry, &versions[i],
759 &qcom_image_variant_ops);
760 debugfs_create_file("oem", 0444, dentry, &versions[i],
761 &qcom_image_oem_ops);
762 }
763 }
764
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-04-26 16:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 13:59 [PATCH v2 1/3] soc: qcom: socinfo: Add support for new fields in revision 20 Mukesh Ojha
2025-04-25 13:59 ` [PATCH v2 2/3] soc: qcom: socinfo: Add support for new fields in revision 21 Mukesh Ojha
2025-04-25 17:28 ` Dmitry Baryshkov
2025-05-08 15:37 ` Mukesh Ojha
2025-05-08 15:56 ` Dmitry Baryshkov
2025-05-08 16:48 ` Mukesh Ojha
2025-05-08 18:01 ` Konrad Dybcio
2025-05-09 10:06 ` Mukesh Ojha
2025-05-09 22:46 ` Konrad Dybcio
2025-04-25 13:59 ` [PATCH v2 3/3] soc: qcom: socinfo: Add support for new fields in revision 22 Mukesh Ojha
2025-04-25 17:29 ` Dmitry Baryshkov
2025-04-25 17:29 ` [PATCH v2 1/3] soc: qcom: socinfo: Add support for new fields in revision 20 Dmitry Baryshkov
2025-04-25 19:18 ` Konrad Dybcio
2025-04-26 16:28 ` kernel test robot [this message]
2025-04-26 17:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504270011.Jftyvklb-lkp@intel.com \
--to=lkp@intel.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.