From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F567C369D5 for ; Mon, 28 Apr 2025 12:29:48 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id CE9053CBADE for ; Mon, 28 Apr 2025 14:29:46 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id EDA9C3CB6CF for ; Mon, 28 Apr 2025 14:29:30 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 505491000A2C for ; Mon, 28 Apr 2025 14:29:29 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 166B821210; Mon, 28 Apr 2025 12:29:28 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DD5821336F; Mon, 28 Apr 2025 12:29:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id lq2UM6d0D2gwUAAAD6G6ig (envelope-from ); Mon, 28 Apr 2025 12:29:27 +0000 Date: Mon, 28 Apr 2025 14:29:25 +0200 From: Petr Vorel To: Martin Doucha Message-ID: <20250428122925.GA98442@pevik> References: <20250407142351.25900-1-mdoucha@suse.cz> <20250407142351.25900-4-mdoucha@suse.cz> <20250416062255.GB560513@pevik> <20250416071621.GA572828@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU] X-Rspamd-Queue-Id: 166B821210 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Virus-Scanned: clamav-milter 1.0.7 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 3/5] KVM: Simplify reading VMX control field masks X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Martin, > Hi! > On 16. 04. 25 9:16, Petr Vorel wrote: > > Hi Martin, > > > Hi Martin, > > > ... > > > > /* Configure VM execution control fields */ > > > > - if (kvm_rdmsr(MSR_IA32_VMX_BASIC) & IA32_VMXBASIC_USELESS_CTL_MASKS) { > > > > - pinxctl = (uint32_t)kvm_rdmsr(MSR_IA32_VMX_PINX_MASK2); > > > > - execctl = (uint32_t)kvm_rdmsr(MSR_IA32_VMX_EXECCTL_MASK2); > > > > - exitctl = (uint32_t)kvm_rdmsr(MSR_IA32_VMX_EXITCTL_MASK2); > > > > - entryctl = (uint32_t)kvm_rdmsr(MSR_IA32_VMX_ENTRYCTL_MASK2); > > > > - } else { > > > > - pinxctl = (uint32_t)kvm_rdmsr(MSR_IA32_VMX_PINX_MASK); > > > > - execctl = (uint32_t)kvm_rdmsr(MSR_IA32_VMX_EXECCTL_MASK); > > > > - exitctl = (uint32_t)kvm_rdmsr(MSR_IA32_VMX_EXITCTL_MASK); > > > > - entryctl = (uint32_t)kvm_rdmsr(MSR_IA32_VMX_ENTRYCTL_MASK); > > The rest of the patchset merged, thank you! > > > I guess you're going to use in the future MSR_IA32_VMX_PINX_MASK2 and other > > > deleted masks (because now they are IMHO only in the structs). > > If you don't need the constants in the future, please remove it in a subsequent > > patch. > Those constants are still used in kvm_vmx_read_vmctl_mask() via the static > lookup table in lib_x86.c. We can't remove them because the tests would > break on old CPUs. Good to know, thanks for info! Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp