All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Timur Tabi <ttabi@nvidia.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] docs: debugfs: do not recommend debugfs_remove_recursive
Date: Tue, 29 Apr 2025 19:47:36 +0200	[thread overview]
Message-ID: <2025042900-emblaze-enlarged-47e8@gregkh> (raw)
In-Reply-To: <20250429173958.3973958-1-ttabi@nvidia.com>

On Tue, Apr 29, 2025 at 12:39:58PM -0500, Timur Tabi wrote:
> Update the debugfs documentation to indicate that debugfs_remove()
> should be used to clean up debugfs entries.
> 
> In commit a3d1e7eb5abe ("simple_recursive_removal(): kernel-side rm -rf
> for ramfs-style filesystems"), function debugfs_remove_recursive()
> was made into an alias for debugfs_remove():
> 
>     #define debugfs_remove_recursive debugfs_remove
> 
> Therefore, drivers should just use debugfs_remove() going forward.

No, the other way around, we should be telling people to use
debugfs_remove_recursive() instead please, and getting rid of
debugfs_remove() entirely.

thanks,

greg k-h

  reply	other threads:[~2025-04-29 18:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 17:39 [PATCH] docs: debugfs: do not recommend debugfs_remove_recursive Timur Tabi
2025-04-29 17:47 ` Greg Kroah-Hartman [this message]
2025-04-29 18:24   ` Timur Tabi
2025-04-30  7:30     ` gregkh
2025-04-30 14:27       ` Timur Tabi
2025-04-30 14:57         ` gregkh
2025-04-30 16:36           ` Timur Tabi
2025-04-30 17:10             ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025042900-emblaze-enlarged-47e8@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=ttabi@nvidia.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.