From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib/tlibio: Get rid of support for old UNIXes
Date: Tue, 29 Apr 2025 10:43:11 +0200 [thread overview]
Message-ID: <20250429084311.GA238584@pevik> (raw)
In-Reply-To: <20250408161745.9757-1-chrubis@suse.cz>
Hi Cyril,
> Removes support for obsolete UNIXes CRAY, sgi, etc.
> Also removes the UCLIBC ifdefs that disabled most of the code because
> aio is not supported on UCLIBC.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Great work, thanks!
Removing unused code is always useful.
Code is really old and would deserve refactoring.
Kind regards,
Petr
tlibio.c: In function ‘lio_write_buffer’:
tlibio.c:617:17: warning: ‘sigset’ is deprecated: Use the signal and sigprocmask functions instead [-Wdeprecated-declarations]
617 | sigset(sig, lio_async_signal_handler);
| ^~~~~~
In file included from /usr/include/x86_64-linux-gnu/sys/param.h:28,
from tlibio.c:83:
/usr/include/signal.h:367:23: note: declared here
367 | extern __sighandler_t sigset (int __sig, __sighandler_t __disp) __THROW
| ^~~~~~
tlibio.c:698:25: warning: ‘sighold’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
698 | sighold(sig);
| ^~~~~~~
/usr/include/signal.h:355:12: note: declared here
355 | extern int sighold (int __sig) __THROW
| ^~~~~~~
tlibio.c:705:33: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
705 | sigrelse(sig);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
tlibio.c:725:25: warning: ‘sighold’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
725 | sighold(sig);
| ^~~~~~~
/usr/include/signal.h:355:12: note: declared here
355 | extern int sighold (int __sig) __THROW
| ^~~~~~~
tlibio.c:732:33: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
732 | sigrelse(sig);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
tlibio.c:759:25: warning: ‘sighold’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
759 | sighold(sig);
| ^~~~~~~
/usr/include/signal.h:355:12: note: declared here
355 | extern int sighold (int __sig) __THROW
| ^~~~~~~
tlibio.c:766:33: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
766 | sigrelse(sig);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
tlibio.c:507:22: warning: unused parameter ‘wrd’ [-Wunused-parameter]
507 | long wrd) /* to allow future features, use zero for now */
| ~~~~~^~~
tlibio.c: In function ‘lio_read_buffer’:
tlibio.c:999:17: warning: ‘sigset’ is deprecated: Use the signal and sigprocmask functions instead [-Wdeprecated-declarations]
999 | sigset(sig, lio_async_signal_handler);
| ^~~~~~
/usr/include/signal.h:367:23: note: declared here
367 | extern __sighandler_t sigset (int __sig, __sighandler_t __disp) __THROW
| ^~~~~~
tlibio.c:1080:25: warning: ‘sighold’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1080 | sighold(sig);
| ^~~~~~~
/usr/include/signal.h:355:12: note: declared here
355 | extern int sighold (int __sig) __THROW
| ^~~~~~~
tlibio.c:1087:33: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1087 | sigrelse(sig);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
tlibio.c:1107:25: warning: ‘sighold’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1107 | sighold(sig);
| ^~~~~~~
/usr/include/signal.h:355:12: note: declared here
355 | extern int sighold (int __sig) __THROW
| ^~~~~~~
tlibio.c:1114:33: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1114 | sigrelse(sig);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
tlibio.c:1141:25: warning: ‘sighold’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1141 | sighold(sig);
| ^~~~~~~
/usr/include/signal.h:355:12: note: declared here
355 | extern int sighold (int __sig) __THROW
| ^~~~~~~
tlibio.c:1148:33: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1148 | sigrelse(sig);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
tlibio.c:888:22: warning: unused parameter ‘wrd’ [-Wunused-parameter]
888 | long wrd) /* to allow future features, use zero for now */
| ~~~~~^~~
tlibio.c: In function ‘lio_check_asyncio’:
tlibio.c:1249:17: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1249 | sigrelse(aiocbp->aio_sigevent.sigev_signo);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
tlibio.c: In function ‘lio_wait4asyncio’:
tlibio.c:1389:25: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1389 | sigrelse(aiocbp->aio_sigevent.sigev_signo);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
tlibio.c:1397:25: warning: ‘sigrelse’ is deprecated: Use the sigprocmask function instead [-Wdeprecated-declarations]
1397 | sigrelse(aiocbp->aio_sigevent.sigev_signo);
| ^~~~~~~~
/usr/include/signal.h:359:12: note: declared here
359 | extern int sigrelse (int __sig) __THROW
| ^~~~~~~~
CC lib/tlibio.o
AR libltp.a
RANLIB libltp.a
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-04-29 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 16:17 [LTP] [PATCH] lib/tlibio: Get rid of support for old UNIXes Cyril Hrubis
2025-04-08 17:51 ` Andrea Cervesato via ltp
2025-04-29 8:43 ` Petr Vorel [this message]
2025-04-29 8:46 ` Andrea Cervesato via ltp
2025-04-29 11:39 ` Cyril Hrubis
2025-04-30 12:42 ` Avinesh Kumar
2025-04-30 13:08 ` Avinesh Kumar
2025-04-30 13:33 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429084311.GA238584@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.