From: Heiko Carstens <hca@linux.ibm.com>
To: Kairui Song <kasong@tencent.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm, swap: fix false warning for large allocation with !THP_SWAP
Date: Tue, 29 Apr 2025 12:08:31 +0200 [thread overview]
Message-ID: <20250429100831.8629C3b-hca@linux.ibm.com> (raw)
In-Reply-To: <20250429094803.85518-1-ryncsn@gmail.com>
On Tue, Apr 29, 2025 at 05:48:03PM +0800, Kairui Song wrote:
> From: Kairui Song <kasong@tencent.com>
>
> The !CONFIG_THP_SWAP check existed before just fine because slot
> cache would reject high order allocation and let the caller split
> all folios and try again.
>
> But slot cache is gone, so large allocation will directly go
> to the allocator, and the allocator should just fail silently
> to inform caller to do the folio split, this is totally fine
> and expected.
>
> Remove this meaning less warning.
>
> Fixes: 0ff67f990bd4 ("mm, swap: remove swap slot cache")
> Reported-by: Heiko Carstens <hca@linux.ibm.com>
> Closes: https://lore.kernel.org/linux-mm/20250428135252.25453B17-hca@linux.ibm.com/
> Signed-off-by: Kairui Song <kasong@tencent.com>
> ---
> mm/swapfile.c | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
Tested-by: Heiko Carstens <hca@linux.ibm.com>
prev parent reply other threads:[~2025-04-29 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 9:48 [PATCH] mm, swap: fix false warning for large allocation with !THP_SWAP Kairui Song
2025-04-29 10:08 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429100831.8629C3b-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.