All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: tools@kernel.org
Subject: [PATCH] Fix misleading error message on cherry-picked patches
Date: Tue, 29 Apr 2025 08:40:17 -0500	[thread overview]
Message-ID: <20250429134017.3796512-1-robh@kernel.org> (raw)

When passing '-P1,2,3' to cherry-pick specific patches, b4 erroneously
logs error messages:

Unknown range value specified: 1
Unknown range value specified: 2
Unknown range value specified: 3

The actual cherry-picking works correctly.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 src/b4/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/b4/__init__.py b/src/b4/__init__.py
index de324d0f714b..ee0196cae118 100644
--- a/src/b4/__init__.py
+++ b/src/b4/__init__.py
@@ -3666,7 +3666,7 @@ def parse_int_range(intrange: str, upper: int) -> Iterator[int]:
                 yield i
             else:
                 logger.critical('Unknown range value specified: %s', n)
-                continue
+            continue
         except ValueError:
             pass
 
-- 
2.47.2


             reply	other threads:[~2025-04-29 13:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 13:40 Rob Herring (Arm) [this message]
2025-04-29 20:43 ` [PATCH] Fix misleading error message on cherry-picked patches Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250429134017.3796512-1-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.