All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: carlos.bilbao@kernel.org, tglx@linutronix.de, seanjc@google.com,
	jan.glauber@gmail.com, bilbao@vt.edu, pmladek@suse.com,
	jani.nikula@intel.com, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, takakura@valinux.co.jp,
	john.ogness@linutronix.de, x86@kernel.org
Subject: Re: [PATCH v3 0/2] Reduce CPU consumption after panic
Date: Tue, 29 Apr 2025 23:06:50 +0200	[thread overview]
Message-ID: <20250429210650.GD4439@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250429133941.063544bb4731df0ef802440c@linux-foundation.org>

On Tue, Apr 29, 2025 at 01:39:41PM -0700, Andrew Morton wrote:
> (cc more x86 people)
> 
> On Tue, 29 Apr 2025 10:06:36 -0500 carlos.bilbao@kernel.org wrote:
> 
> > From: Carlos Bilbao <carlos.bilbao@kernel.org>
> > 
> > Provide a priority-based mechanism to set the behavior of the kernel at
> > the post-panic stage -- the current default is a waste of CPU except for
> > cases with console that generate insightful output.
> > 
> > In v1 cover letter [1], I illustrated the potential to reduce unnecessary
> > CPU resources with an experiment with VMs, reducing more than 70% of CPU
> > usage. The main delta of v2 [2] was that, instead of a weak function that
> > archs can overwrite, we provided a flexible priority-based mechanism
> > (following suggestions by Sean Christopherson), panic_set_handling().
> > 
> 
> An effect of this is that the blinky light will never again occur on
> any x86, I think?  I don't know what might the effects of changing such
> longstanding behavior.
> 
> Also, why was the `priority' feature added?  It has no effect in this
> patchset.

It does what now, and why?

Not being copied on anything, the first reaction is, its panic, your
machine is dead, who cares about power etc..

  parent reply	other threads:[~2025-04-29 21:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 15:06 [PATCH v3 0/2] Reduce CPU consumption after panic carlos.bilbao
2025-04-29 15:06 ` [PATCH v3 1/2] panic: Allow for dynamic custom behavior " carlos.bilbao
2025-04-29 15:06 ` [PATCH v3 2/2] x86/panic: Add x86_panic_handler as default post-panic behavior carlos.bilbao
2025-04-29 20:39 ` [PATCH v3 0/2] Reduce CPU consumption after panic Andrew Morton
2025-04-29 20:17   ` Carlos Bilbao
2025-04-29 22:53     ` Andrew Morton
2025-04-29 21:39       ` Carlos Bilbao
2025-04-29 21:06   ` Peter Zijlstra [this message]
2025-04-29 20:32     ` Carlos Bilbao
2025-04-29 22:10       ` Peter Zijlstra
2025-04-29 20:52         ` Carlos Bilbao
2025-04-30  8:48           ` Peter Zijlstra
2025-04-30 15:59             ` Sean Christopherson
2025-04-30 18:54             ` Carlos Bilbao
2025-05-01  8:55               ` Peter Zijlstra
2025-05-07 19:49                 ` Carlos Bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250429210650.GD4439@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=bilbao@vt.edu \
    --cc=carlos.bilbao@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jan.glauber@gmail.com \
    --cc=jani.nikula@intel.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=seanjc@google.com \
    --cc=takakura@valinux.co.jp \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.