From: Greg KH <gregkh@linuxfoundation.org>
To: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Cc: Sasha Levin <sashal@kernel.org>, stable@vger.kernel.org
Subject: Re: Build failure due to backport of "bpf: Add namespace to BPF internal symbols"
Date: Tue, 29 Apr 2025 07:52:00 +0200 [thread overview]
Message-ID: <2025042944-impound-junkman-ef2c@gregkh> (raw)
In-Reply-To: <d5qsidvulna547jx6tyrjnocvqlddfpsmy6nqlbjss6dt3xbg5@zeqfjvfng25a>
On Tue, Apr 29, 2025 at 10:52:28AM +0800, Shung-Hsi Yu wrote:
> Hi Sasha,
>
> bpf-add-namespace-to-bpf-internal-symbols.patch is stable-queue.git
> seems like the culprit responsible for build failure in stable 6.12 and
> earlier (log below). The reason is likely due to the lack of commit
> cdd30ebb1b9f ("module: Convert symbol namespace to string literal")
> before v6.13. Getting rid of the quotes s/"BPF_INTERNAL"/BPF_INTERNAL/
> probably would be enough to fix it.
>
> In file included from .vmlinux.export.c:1:
> .vmlinux.export.c:1697:33: error: expected ‘)’ before ‘BPF_INTERNAL’
> 1697 | KSYMTAB_FUNC(bpf_map_get, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> ./include/linux/export-internal.h:45:28: note: in definition of macro ‘__KSYMTAB’
> 45 | " .asciz \"" ns "\"" "\n" \
> | ^~
> .vmlinux.export.c:1697:1: note: in expansion of macro ‘KSYMTAB_FUNC’
> 1697 | KSYMTAB_FUNC(bpf_map_get, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> ./include/linux/export-internal.h:41:12: note: to match this ‘(’
> 41 | asm(" .section \"__ksymtab_strings\",\"aMS\",%progbits,1" "\n" \
> | ^
> ./include/linux/export-internal.h:62:41: note: in expansion of macro ‘__KSYMTAB’
> 62 | #define KSYMTAB_FUNC(name, sec, ns) __KSYMTAB(name, KSYM_FUNC(name), sec, ns)
> | ^~~~~~~~~
> .vmlinux.export.c:1697:1: note: in expansion of macro ‘KSYMTAB_FUNC’
> 1697 | KSYMTAB_FUNC(bpf_map_get, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> .vmlinux.export.c:1706:42: error: expected ‘)’ before ‘BPF_INTERNAL’
> 1706 | KSYMTAB_FUNC(bpf_link_get_from_fd, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> ./include/linux/export-internal.h:45:28: note: in definition of macro ‘__KSYMTAB’
> 45 | " .asciz \"" ns "\"" "\n" \
> | ^~
> .vmlinux.export.c:1706:1: note: in expansion of macro ‘KSYMTAB_FUNC’
> 1706 | KSYMTAB_FUNC(bpf_link_get_from_fd, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> ./include/linux/export-internal.h:41:12: note: to match this ‘(’
> 41 | asm(" .section \"__ksymtab_strings\",\"aMS\",%progbits,1" "\n" \
> | ^
> ./include/linux/export-internal.h:62:41: note: in expansion of macro ‘__KSYMTAB’
> 62 | #define KSYMTAB_FUNC(name, sec, ns) __KSYMTAB(name, KSYM_FUNC(name), sec, ns)
> | ^~~~~~~~~
> .vmlinux.export.c:1706:1: note: in expansion of macro ‘KSYMTAB_FUNC’
> 1706 | KSYMTAB_FUNC(bpf_link_get_from_fd, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> .vmlinux.export.c:1708:34: error: expected ‘)’ before ‘BPF_INTERNAL’
> 1708 | KSYMTAB_FUNC(kern_sys_bpf, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> ./include/linux/export-internal.h:45:28: note: in definition of macro ‘__KSYMTAB’
> 45 | " .asciz \"" ns "\"" "\n" \
> | ^~
> .vmlinux.export.c:1708:1: note: in expansion of macro ‘KSYMTAB_FUNC’
> 1708 | KSYMTAB_FUNC(kern_sys_bpf, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> ./include/linux/export-internal.h:41:12: note: to match this ‘(’
> 41 | asm(" .section \"__ksymtab_strings\",\"aMS\",%progbits,1" "\n" \
> | ^
> ./include/linux/export-internal.h:62:41: note: in expansion of macro ‘__KSYMTAB’
> 62 | #define KSYMTAB_FUNC(name, sec, ns) __KSYMTAB(name, KSYM_FUNC(name), sec, ns)
> | ^~~~~~~~~
> .vmlinux.export.c:1708:1: note: in expansion of macro ‘KSYMTAB_FUNC’
> 1708 | KSYMTAB_FUNC(kern_sys_bpf, "", ""BPF_INTERNAL"");
> | ^~~~~~~~~~~~
> make[2]: *** [scripts/Makefile.vmlinux:18: .vmlinux.export.o] Error 1
> make[1]: *** [/home/runner/work/libbpf/libbpf/.kernel/Makefile:1184: vmlinux] Error 2
> make: *** [Makefile:224: __sub-make] Error 2
Good catch, let me go fix this up...
thanks,
greg k-h
prev parent reply other threads:[~2025-04-29 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 2:52 Build failure due to backport of "bpf: Add namespace to BPF internal symbols" Shung-Hsi Yu
2025-04-29 5:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042944-impound-junkman-ef2c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=sashal@kernel.org \
--cc=shung-hsi.yu@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.